Forward accessibility events to the automation extension process.

chrome/renderer/extensions/automation_internal_custom_bindings.h

Index: chrome/renderer/extensions/automation_internal_custom_bindings.h
diff --git a/chrome/renderer/extensions/automation_internal_custom_bindings.h b/chrome/renderer/extensions/automation_internal_custom_bindings.h
index ffa7085e3eac934f0b2a9264afce51a55b121286..8ba81d054fddf2537040c417a8c7d6c1d0edb111 100644
--- a/chrome/renderer/extensions/automation_internal_custom_bindings.h
+++ b/chrome/renderer/extensions/automation_internal_custom_bindings.h
@@ -5,20 +5,32 @@
 #ifndef CHROME_RENDERER_EXTENSIONS_AUTOMATION_INTERNAL_CUSTOM_BINDINGS_H_
 #define CHROME_RENDERER_EXTENSIONS_AUTOMATION_INTERNAL_CUSTOM_BINDINGS_H_
 
+#include <vector>

[not at google - send to devlin, 2015/06/02 23:59:25]

unused? also the scoped_ptr include and maybe the hash_tables include?

[dmazzoni, 2015/06/04 20:07:39]

Done.

+
 #include "base/compiler_specific.h"
+#include "base/containers/hash_tables.h"
+#include "base/memory/scoped_ptr.h"
+#include "chrome/renderer/extensions/chrome_v8_extension_handler.h"
 #include "extensions/renderer/object_backed_native_handler.h"
+#include "ui/accessibility/ax_tree.h"
 #include "v8/include/v8.h"
 
+struct ExtensionMsg_AccessibilityEventParams;
+
 namespace extensions {
 
 // The native component of custom bindings for the chrome.automationInternal
 // API.
-class AutomationInternalCustomBindings : public ObjectBackedNativeHandler {
+class AutomationInternalCustomBindings : public ObjectBackedNativeHandler,
+                                         public ChromeV8ExtensionHandler {

[not at google - send to devlin, 2015/06/02 23:59:25]

ChromeV8ExtensionHandler is not a nice class, it's unnecessary as a superclass
(and in this case breaks multiple inheritance rules).

(the history is that most of its functionality has either been deleted or moved
into ObjectBackedNativeHandler, except for that routing ID stuff. It has nothing
to do with v8 anymore)

Proposal: pull its functionality into a composable object, let's say
IPCEndpoint:

class IPCEndpoint {
 public:
  explicit IPCEndpoint(IPC::Listener* listener);
  int GetRoutingID();
  void Send(IPC::Message* message);
 private:
  int routing_id_;
}

IPCEndpoint::IPCEndpoint() : routing_id_(-1) {}
// More or less the contents of chrome_v8_extension_handler.

Then have an IPCEndpoint as a member variable of this class to send to, and make
this class extend IPC::Listener instead of ChromeV8ExtensionHandler.

I wonder if that would let me delete ChromeV8ExtensionHandler actually.

[dmazzoni, 2015/06/04 20:07:39]

As discussed I'll go with a MessageFilter instead, there's no reason we need a
separate routing id here.

  public:
   explicit AutomationInternalCustomBindings(ScriptContext* context);
 
   ~AutomationInternalCustomBindings() override;
 
+  // IPC::Listener
+  bool OnMessageReceived(const IPC::Message& message) override;
+
  private:
   // Returns whether this extension has the "interact" permission set (either
   // explicitly or implicitly after manifest parsing).
@@ -28,6 +40,10 @@ class AutomationInternalCustomBindings : public ObjectBackedNativeHandler {
   // chrome.automation namespace.
   void GetSchemaAdditions(const v8::FunctionCallbackInfo<v8::Value>& args);
 
+  // Handle accessibility events from the browser process.
+  void OnAccessibilityEvent(
+      const ExtensionMsg_AccessibilityEventParams& params);
+
   DISALLOW_COPY_AND_ASSIGN(AutomationInternalCustomBindings);
 };