Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1151513002: ChromeOS Offline gaia: Don't do reload when using local (offline) gaia (Closed)

Created:
5 years, 7 months ago by Roman Sorokin (ftl)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS Offline gaia: Don't do reload when using local (offline) gaia Reason for this when build with Memory Sanitizer it causes delay between CallJS('...') and actual JS execution. In this particular case Chrome tries to CallJS('doReload') due to frame loading error. After that it loads offline Gaia and then function |doReload| starts to execute which causes hiding offline Gaia; BUG=475516 Committed: https://crrev.com/0f36deb42826376c5d7b6b5d024d4c3f32f86191 Cr-Commit-Position: refs/heads/master@{#330920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M chrome/browser/chromeos/login/login_browsertest.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151513002/1
5 years, 7 months ago (2015-05-20 12:12:00 UTC) #2
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 7 months ago (2015-05-20 12:12:03 UTC) #4
Roman Sorokin (ftl)
Hi Pavel, please review. Hi Xiyuan, please review.
5 years, 7 months ago (2015-05-20 12:23:46 UTC) #6
xiyuan
LGTM Thank you for the quick fix.
5 years, 7 months ago (2015-05-20 15:54:29 UTC) #7
dzhioev (left Google)
On 2015/05/20 15:54:29, xiyuan wrote: > LGTM > > Thank you for the quick fix. ...
5 years, 7 months ago (2015-05-20 22:46:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151513002/1
5 years, 7 months ago (2015-05-21 08:54:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 09:30:48 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 09:31:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f36deb42826376c5d7b6b5d024d4c3f32f86191
Cr-Commit-Position: refs/heads/master@{#330920}

Powered by Google App Engine
This is Rietveld 408576698