Remove redundant functions my_strncpy() and my_strncat()

Remove redundant functions my_strncpy() and my_strncat()

my_strlcpy() and my_strlcat() should be used instead.

BUG=None
TEST=On an Android phone, opening chrome://inducebrowsercrashforrealz results in adding a new crash report to chrome://crashes

Committed: https://crrev.com/049996311153997f3c5aaf178b44d9208ccc0f4f
Cr-Commit-Position: refs/heads/master@{#333213}

[hashimoto, 2015-06-05 07:02:28]

Patchset #1 (id:1) has been deleted

[hashimoto, 2015-06-05 07:02:42]

hashimoto@chromium.org changed reviewers:
+ thestig@chromium.org

[hashimoto, 2015-06-05 07:02:43]

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
File components/crash/app/breakpad_linux.cc (left):

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
components/crash/app/breakpad_linux.cc:1551: WriteLog(info.filename,
filename_length - 1);
WriteLog's Android implementation ignores the second parameter, but it should be
nice to do it right.

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
components/crash/app/breakpad_linux.cc:1558: unsigned done_filename_len =
filename_length - 1 + pid_str_length;
IIUC the existing code writes more bytes than allocated to |done_filename|.

[Lei Zhang, 2015-06-05 18:24:09]

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
File components/crash/app/breakpad_linux.cc (left):

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
components/crash/app/breakpad_linux.cc:1558: unsigned done_filename_len =
filename_length - 1 + pid_str_length;
On 2015/06/05 07:02:43, hashimoto wrote:
> IIUC the existing code writes more bytes than allocated to |done_filename|.

Yes, it's full of fail. :(

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
File components/crash/app/breakpad_linux.cc (right):

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
components/crash/app/breakpad_linux.cc:1545: WriteLog(done_filename,
done_filename_len);
The -1 should remain here, right?

[hashimoto, 2015-06-06 02:11:05]

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
File components/crash/app/breakpad_linux.cc (right):

https://codereview.chromium.org/1151503007/diff/20001/components/crash/app/br...
components/crash/app/breakpad_linux.cc:1545: WriteLog(done_filename,
done_filename_len);
On 2015/06/05 18:24:09, Lei Zhang wrote:
> The -1 should remain here, right?

Ugh, you're right.
Fixed.

[Lei Zhang, 2015-06-06 02:34:20]

lgtm and thank you for fixing this.

[Lei Zhang, 2015-06-06 04:45:47]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-06-06 04:45:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151503007/40001

[commit-bot: I haz the power, 2015-06-06 04:48:59]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-06-06 04:49:49]

Patchset 2 (id:??) landed as
https://crrev.com/049996311153997f3c5aaf178b44d9208ccc0f4f
Cr-Commit-Position: refs/heads/master@{#333213}