[sync] Componentize sync: Part 2: Add SYNC_EXPORTs to files in src/sync/

sync/internal_api/public/util/weak_handle.h

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Weak handles provides a way to refer to weak pointers from another
 // thread.  This is useful because it is not safe to reference a weak
 // pointer from a thread other than the thread on which it was
 // created.
 //
 // Weak handles can be passed across threads, so for example, you can
 // use them to do the "real" work on one thread and get notified on
@@ skipping 39 matching lines @@
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback_forward.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
+#include "sync/base/sync_export.h"
 
 namespace base {
 class MessageLoopProxy;
 }  // namespace base
 
 namespace tracked_objects {
 class Location;
 }  // namespace tracked_objects
 
 namespace syncer {
@@ skipping 21 matching lines @@
   typedef const T* ForwardType;
 };
 
 template <typename T>
 struct ParamTraits<T[]> {
   typedef const T* ForwardType;
 };
 
 // Base class for WeakHandleCore<T> to avoid template bloat.  Handles
 // the interaction with the owner thread and its message loop.
-class WeakHandleCoreBase {
+class SYNC_EXPORT WeakHandleCoreBase {

[akalin, 2012/12/11 00:02:52]

hmm.  Can you see if you can avoid exporting this and instead have
WeakHandleCore annotate its inheritance of WeakHandleCoreBase with
NON_EXPORTED_BASE()?

[Raghu Simha, 2012/12/11 01:27:51]

Done.

  public:
   // Assumes the current thread is the owner thread.
   WeakHandleCoreBase();
 
   // May be called on any thread.
   bool IsOnOwnerThread() const;
 
  protected:
   // May be destroyed on any thread.
   ~WeakHandleCoreBase();
@@ skipping 256 matching lines @@
 
 // Makes a WeakHandle from a WeakPtr.
 template <typename T>
 WeakHandle<T> MakeWeakHandle(const base::WeakPtr<T>& ptr) {
   return WeakHandle<T>(ptr);
 }
 
 }  // namespace syncer
 
 #endif  // SYNC_UTIL_WEAK_HANDLE_H_