[sync] Componentize sync: Part 2: Add SYNC_EXPORTs to files in src/sync/

sync/internal_api/public/change_record.h

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_PUBLIC_API_CHANGE_RECORD_H_
 #define SYNC_INTERNAL_PUBLIC_API_CHANGE_RECORD_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/memory/linked_ptr.h"
+#include "sync/base/sync_export.h"
 #include "sync/internal_api/public/util/immutable.h"
 #include "sync/protocol/password_specifics.pb.h"
 #include "sync/protocol/sync.pb.h"
 
 namespace base {
 class DictionaryValue;
 }  // namespace base
 
 namespace syncer {
 
 // TODO(zea): One day get passwords playing nicely with the rest of encryption
 // and get rid of this.
 class ExtraPasswordChangeRecordData {
  public:
   ExtraPasswordChangeRecordData();
   explicit ExtraPasswordChangeRecordData(
       const sync_pb::PasswordSpecificsData& data);
   virtual ~ExtraPasswordChangeRecordData();
 
   // Transfers ownership of the DictionaryValue to the caller.
   virtual base::DictionaryValue* ToValue() const;
 
-  const sync_pb::PasswordSpecificsData& unencrypted() const;
+  SYNC_EXPORT const sync_pb::PasswordSpecificsData& unencrypted() const;

[akalin, 2012/12/11 00:02:52]

isn't this an error?  Shouldn't it be the class that has this annotation?

[Raghu Simha, 2012/12/11 01:27:51]

Interesting. I was initially trying to export the bare minimum required to get a
component build going. I've changed all method-only exports to class exports.

Fixed.

  private:
   sync_pb::PasswordSpecificsData unencrypted_;
 };
 
 // ChangeRecord indicates a single item that changed as a result of a sync
 // operation.  This gives the sync id of the node that changed, and the type
 // of change.  To get the actual property values after an ADD or UPDATE, the
 // client should get the node with InitByIdLookup(), using the provided id.
 struct ChangeRecord {
   enum Action {
@@ skipping 13 matching lines @@
   linked_ptr<ExtraPasswordChangeRecordData> extra;
 };
 
 typedef std::vector<ChangeRecord> ChangeRecordList;
 
 typedef Immutable<ChangeRecordList> ImmutableChangeRecordList;
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_CHANGE_RECORD_H_