Delay updating jumplist to avoid blocking the file thread at start-up

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 119 matching lines @@
 #include "chrome/browser/ui/ash/launcher/browser_launcher_item_controller.h"
 #include "chrome/browser/ui/ash/window_positioner.h"
 #endif
 
 #if defined(USE_AURA)
 #include "chrome/browser/ui/views/accelerator_table.h"
 #include "chrome/browser/ui/webui/task_manager/task_manager_dialog.h"
 #include "ui/aura/window.h"
 #include "ui/gfx/screen.h"
 #elif defined(OS_WIN)  // !defined(USE_AURA)
+#include "chrome/browser/jumplist_listener.h"
 #include "chrome/browser/jumplist_win.h"
 #include "chrome/browser/ui/views/omnibox/omnibox_view_win.h"
 #include "ui/views/widget/native_widget_win.h"
 #include "ui/views/win/scoped_fullscreen_visibility.h"
 #endif
 
 #if defined(OS_WIN)
 #include "win8/util/win8_util.h"
 #endif
 
@@ skipping 2066 matching lines @@
       views::Background::CreateSolidBackground(bg_color));
   AddChildView(contents_split_);
   set_contents_view(contents_split_);
 
   status_bubble_.reset(new StatusBubbleViews(contents_));
 
 #if defined(OS_WIN) && !defined(USE_AURA)
   // Create a custom JumpList and add it to an observer of TabRestoreService
   // so we can update the custom JumpList when a tab is added or removed.
   if (JumpList::Enabled()) {
-    jumplist_ = new JumpList();
-    jumplist_->AddObserver(browser_->profile());
+    jumplist_listener_ .reset(new JumpListListener(

[sky, 2012/12/18 20:52:38]

You've got a space after jumplist_listener_

[Cait (Slow), 2012/12/19 19:27:01]

Done.

+        base::Bind(&BrowserView::CreateJumpList, base::Unretained(this))));
   }
 #endif
 
   // We're now initialized and ready to process Layout requests.
   ignore_layout_ = false;
 }
 
 void BrowserView::LoadingAnimationCallback() {
   base::TimeTicks now = base::TimeTicks::Now();
   if (!last_animation_time_.is_null()) {
@@ skipping 563 matching lines @@
     modal_browser->window()->Activate();
   }
 
   AppModalDialogQueue::GetInstance()->ActivateModalDialog();
 }
 
 void BrowserView::MaybeStackBookmarkBarAtTop() {
   if (bookmark_bar_view_.get())
     bookmark_bar_view_->MaybeStackAtTop();
 }
+
+#if defined(OS_WIN) && !defined(USE_AURA)
+void BrowserView::CreateJumpList() {
+  if (!jumplist_) {

[sky, 2012/12/18 20:52:38]

Why the if check here? It should be a DCHECK.

[Cait (Slow), 2012/12/19 19:27:01]

Done.

+    jumplist_ = new JumpList();
+    jumplist_->AddObserver(browser_->profile());
+  }
+}
+#endif