Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1151483002: [ARM64] [turbofan] Use 'mvn' rather than an equivalent 'orn'. (Closed)

Created:
5 years, 7 months ago by jbramley
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM64] [turbofan] Use 'mvn' rather than an equivalent 'orn'. `mvn xd, xn` is an architectural alias for `orn xd, xzr, xm`, so this doesn't change code generation at all, but it's tidier and it addresses a TODO. BUG= Committed: https://crrev.com/f88606e25dc45100bb2d3975f113e34d22f5e3d1 Cr-Commit-Position: refs/heads/master@{#28507}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbramley
5 years, 7 months ago (2015-05-20 10:38:14 UTC) #2
Benedikt Meurer
lgtm
5 years, 7 months ago (2015-05-20 10:41:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151483002/1
5 years, 7 months ago (2015-05-20 10:41:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 11:04:40 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 11:05:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f88606e25dc45100bb2d3975f113e34d22f5e3d1
Cr-Commit-Position: refs/heads/master@{#28507}

Powered by Google App Engine
This is Rietveld 408576698