Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: go/src/infra/gae/libs/meta/eg.go

Issue 1151473003: Better attempt at an appengine wrapper. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: fix coverage numbers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « go/src/infra/gae/libs/context/goon.go ('k') | go/src/infra/gae/libs/wrapper/brokenfeatures.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // +build appengine
6
7 package meta 5 package meta
8 6
9 import ( 7 import (
8 "golang.org/x/net/context"
9
10 "appengine/datastore" 10 "appengine/datastore"
11 11
12 "github.com/luci/luci-go/common/errors" 12 "github.com/luci/luci-go/common/errors"
13 13
14 » "infra/gae/libs/context" 14 » "infra/gae/libs/wrapper"
15 ) 15 )
16 16
17 var mark = errors.MakeMarkFn("eg") 17 var mark = errors.MakeMarkFn("eg")
18 18
19 // EntityGroupMeta is the model corresponding to the __entity_group__ model in 19 // EntityGroupMeta is the model corresponding to the __entity_group__ model in
20 // appengine. You shouldn't need to use this struct directly, but instead should 20 // appengine. You shouldn't need to use this struct directly, but instead should
21 // use GetEntityGroupVersion. 21 // use GetEntityGroupVersion.
22 type EntityGroupMeta struct { 22 type EntityGroupMeta struct {
23 _kind string `datastore:"-" goon:"kind,__entity_group__"` 23 _kind string `datastore:"-" goon:"kind,__entity_group__"`
24 24
25 ID int64 `datastore:"-" goon:"id"` 25 ID int64 `datastore:"-" goon:"id"`
26 Parent *datastore.Key `datastore:"-" goon:"parent"` 26 Parent *datastore.Key `datastore:"-" goon:"parent"`
27 27
28 Version int64 `datastore:"__version__"` 28 Version int64 `datastore:"__version__"`
29 } 29 }
30 30
31 // GetEntityGroupVersion returns the entity group version for the entity group 31 // GetEntityGroupVersion returns the entity group version for the entity group
32 // containing root. If the entity group doesn't exist, this function will return 32 // containing root. If the entity group doesn't exist, this function will return
33 // zero and a nil error. 33 // zero and a nil error.
34 func GetEntityGroupVersion(c context.SingleReadWriter, root *datastore.Key) (int 64, error) { 34 func GetEntityGroupVersion(c context.Context, root *datastore.Key) (int64, error ) {
35 for root.Parent() != nil { 35 for root.Parent() != nil {
36 root = root.Parent() 36 root = root.Parent()
37 } 37 }
38 egm := &EntityGroupMeta{ID: 1, Parent: root} 38 egm := &EntityGroupMeta{ID: 1, Parent: root}
39 » err := c.Get(egm) 39 » err := wrapper.GetDS(c).Get(egm)
40 if err != datastore.ErrNoSuchEntity { 40 if err != datastore.ErrNoSuchEntity {
41 err = mark(err) 41 err = mark(err)
42 } else { 42 } else {
43 // this is OK for callers. The version of the entity group is ef fectively 0 43 // this is OK for callers. The version of the entity group is ef fectively 0
44 // in this case. 44 // in this case.
45 err = nil 45 err = nil
46 } 46 }
47 return egm.Version, err 47 return egm.Version, err
48 } 48 }
OLDNEW
« no previous file with comments | « go/src/infra/gae/libs/context/goon.go ('k') | go/src/infra/gae/libs/wrapper/brokenfeatures.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698