Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Side by Side Diff: src/arm64/assembler-arm64.cc

Issue 1151463002: ARM64: Fix some signed-unsigned comparisons from cdc43bc (r28412). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/assembler-arm64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // 2 //
3 // Redistribution and use in source and binary forms, with or without 3 // Redistribution and use in source and binary forms, with or without
4 // modification, are permitted provided that the following conditions are 4 // modification, are permitted provided that the following conditions are
5 // met: 5 // met:
6 // 6 //
7 // * Redistributions of source code must retain the above copyright 7 // * Redistributions of source code must retain the above copyright
8 // notice, this list of conditions and the following disclaimer. 8 // notice, this list of conditions and the following disclaimer.
9 // * Redistributions in binary form must reproduce the above 9 // * Redistributions in binary form must reproduce the above
10 // copyright notice, this list of conditions and the following 10 // copyright notice, this list of conditions and the following
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 bool Assembler::is_const_pool_blocked() const { 884 bool Assembler::is_const_pool_blocked() const {
885 return (const_pool_blocked_nesting_ > 0) || 885 return (const_pool_blocked_nesting_ > 0) ||
886 (pc_offset() < no_const_pool_before_); 886 (pc_offset() < no_const_pool_before_);
887 } 887 }
888 888
889 889
890 bool Assembler::IsConstantPoolAt(Instruction* instr) { 890 bool Assembler::IsConstantPoolAt(Instruction* instr) {
891 // The constant pool marker is made of two instructions. These instructions 891 // The constant pool marker is made of two instructions. These instructions
892 // will never be emitted by the JIT, so checking for the first one is enough: 892 // will never be emitted by the JIT, so checking for the first one is enough:
893 // 0: ldr xzr, #<size of pool> 893 // 0: ldr xzr, #<size of pool>
894 bool result = instr->IsLdrLiteralX() && (instr->Rt() == xzr.code()); 894 bool result = instr->IsLdrLiteralX() && (instr->Rt() == kZeroRegCode);
895 895
896 // It is still worth asserting the marker is complete. 896 // It is still worth asserting the marker is complete.
897 // 4: blr xzr 897 // 4: blr xzr
898 DCHECK(!result || (instr->following()->IsBranchAndLinkToRegister() && 898 DCHECK(!result || (instr->following()->IsBranchAndLinkToRegister() &&
899 instr->following()->Rn() == xzr.code())); 899 instr->following()->Rn() == kZeroRegCode));
900 900
901 return result; 901 return result;
902 } 902 }
903 903
904 904
905 int Assembler::ConstantPoolSizeAt(Instruction* instr) { 905 int Assembler::ConstantPoolSizeAt(Instruction* instr) {
906 #ifdef USE_SIMULATOR 906 #ifdef USE_SIMULATOR
907 // Assembler::debug() embeds constants directly into the instruction stream. 907 // Assembler::debug() embeds constants directly into the instruction stream.
908 // Although this is not a genuine constant pool, treat it like one to avoid 908 // Although this is not a genuine constant pool, treat it like one to avoid
909 // disassembling the constants. 909 // disassembling the constants.
(...skipping 2275 matching lines...) Expand 10 before | Expand all | Expand 10 after
3185 movz(scratch, (target_offset >> 16) & 0xFFFF, 16); 3185 movz(scratch, (target_offset >> 16) & 0xFFFF, 16);
3186 movk(scratch, (target_offset >> 32) & 0xFFFF, 32); 3186 movk(scratch, (target_offset >> 32) & 0xFFFF, 32);
3187 DCHECK((target_offset >> 48) == 0); 3187 DCHECK((target_offset >> 48) == 0);
3188 add(rd, rd, scratch); 3188 add(rd, rd, scratch);
3189 } 3189 }
3190 3190
3191 3191
3192 } } // namespace v8::internal 3192 } } // namespace v8::internal
3193 3193
3194 #endif // V8_TARGET_ARCH_ARM64 3194 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « no previous file | src/arm64/assembler-arm64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698