Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1151443002: dart2js cps: Fix in how type variables are accessed. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 2f2d997f580e79f3ac8d8571d977a1bd4692ad85..45d75902e0c0b1a9e35f5e6fc740f5faacbaf32d 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -636,10 +636,10 @@ class CodeGenerator extends tree_ir.StatementVisitor
ClassElement context = node.variable.element.enclosingClass;
js.Expression index = js.number(glue.getTypeVariableIndex(node.variable));
if (glue.needsSubstitutionForTypeVariableAccess(context)) {
- js.Expression substitution = glue.getSubstitutionName(context);
+ js.Expression typeName = glue.getRuntimeTypeName(context);
return buildStaticHelperInvocation(
- glue.getTypeArgumentWithSubstitution(),
- [visitExpression(node.target), substitution, index]);
+ glue.getRuntimeTypeArgument(),
+ [visitExpression(node.target), typeName, index]);
} else {
return buildStaticHelperInvocation(
glue.getTypeArgumentByIndex(),
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/codegen/glue.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698