Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 115143004: Updated Khronos GLES2 headers. (Take 2) (Closed)

Created:
7 years ago by bajones
Modified:
6 years, 11 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org
Visibility:
Public.

Description

Updated Khronos GLES2 headers. (Take 2, Original: https://codereview.chromium.org/99053007/) There was a type conflict between the previous, out of date headers and the more recent ones included in ANGLE that was causing failures on 64-bit Windows. BUG=326382 TBR=kbr@chromium.org, piman@chromium.org, raymes@chromium.org, robertphillips@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242740

Patch Set 1 #

Patch Set 2 : Fixed conformance issues #

Patch Set 3 : Update #

Patch Set 4 : Post-Holiday update #

Patch Set 5 : Fixed const-mistmatch and duplicated symbol #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1693 lines, -1849 lines) Patch
M DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 2 chunks +17 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 2 3 28 chunks +230 lines, -121 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_test.gyp View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
M ppapi/c/ppb_opengles2.h View 1 2 3 1 chunk +12 lines, -7 lines 0 comments Download
M skia/skia_common.gypi View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M third_party/khronos/GLES2/gl2.h View 14 chunks +244 lines, -339 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 2 3 4 5 chunks +1126 lines, -1350 lines 0 comments Download
M third_party/khronos/GLES2/gl2platform.h View 2 chunks +3 lines, -16 lines 0 comments Download
M third_party/khronos/KHR/khrplatform.h View 3 chunks +36 lines, -1 line 0 comments Download
M third_party/khronos/README.chromium View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bajones
If you were TBRed on this issue it's because you have already given your LGTM ...
6 years, 11 months ago (2013-12-30 21:16:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/115143004/260003
6 years, 11 months ago (2013-12-30 21:17:17 UTC) #2
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=42927
6 years, 11 months ago (2013-12-30 21:33:05 UTC) #3
bajones
6 years, 11 months ago (2013-12-30 23:34:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #6 manually as r242740.

Powered by Google App Engine
This is Rietveld 408576698