Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 115140: Add script to check out chromium source tree and invoke install-build-deps.sh... (Closed)

Created:
11 years, 7 months ago by dank
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add script to check out chromium source tree and invoke install-build-deps.sh Modify install-build-deps.sh to also install gold if desired.

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -1 line) Patch
A build/bootstrap-linux.sh View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
M build/install-build-deps.sh View 1 2 3 chunks +73 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
dank
Just starting to test... haven't finished pointing gyp at gold yet.
11 years, 7 months ago (2009-05-08 19:32:19 UTC) #1
Evan Martin
11 years, 7 months ago (2009-05-08 19:37:11 UTC) #2
I like the idea of making install-build-deps.sh pull in gold.  I wonder how many
people would use the bootstrap-linux.sh, though.  Part of the reason it's easy
to write such a script for within Google is because the systems are so
homogeneous.

http://codereview.chromium.org/115140/diff/1/2
File build/bootstrap-linux.sh (right):

http://codereview.chromium.org/115140/diff/1/2#newcode61
Line 61: # Retry a few times in case there was a network problem
Maybe we could use the exit code of gclient to do this?

http://codereview.chromium.org/115140/diff/1/3
File build/install-build-deps.sh (right):

http://codereview.chromium.org/115140/diff/1/3#newcode144
Line 144: echo -n "Do you want to install the fast linker to /usr/local/gold/
(y/N) "
Some platforms (like Debian) have gold already available.  Maybe this should be
predicated on the system release or something?

Powered by Google App Engine
This is Rietveld 408576698