Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 1151393003: Add ref-count on RenderViewHost for each new RenderFrameProxyHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Nick's review. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/frame_tree.h ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree.cc
diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc
index f28a6be8e057a925024b33b4dbefcdf1a17f65ac..44b8dab9aa9d4c651c262e290728b9bc48e8bc09 100644
--- a/content/browser/frame_host/frame_tree.cc
+++ b/content/browser/frame_host/frame_tree.cc
@@ -304,24 +304,22 @@ RenderViewHostImpl* FrameTree::GetRenderViewHost(SiteInstance* site_instance) {
return iter->second;
}
-void FrameTree::RegisterRenderFrameHost(
- RenderFrameHostImpl* render_frame_host) {
- SiteInstance* site_instance = render_frame_host->GetSiteInstance();
+void FrameTree::AddRenderViewHostRef(RenderViewHostImpl* render_view_host) {
+ SiteInstance* site_instance = render_view_host->GetSiteInstance();
RenderViewHostMap::iterator iter =
render_view_host_map_.find(site_instance->GetId());
CHECK(iter != render_view_host_map_.end());
+ CHECK(iter->second == render_view_host);
iter->second->increment_ref_count();
}
-void FrameTree::UnregisterRenderFrameHost(
- RenderFrameHostImpl* render_frame_host) {
- SiteInstance* site_instance = render_frame_host->GetSiteInstance();
+void FrameTree::ReleaseRenderViewHostRef(RenderViewHostImpl* render_view_host) {
+ SiteInstance* site_instance = render_view_host->GetSiteInstance();
int32 site_instance_id = site_instance->GetId();
RenderViewHostMap::iterator iter =
render_view_host_map_.find(site_instance_id);
- if (iter != render_view_host_map_.end() &&
- iter->second == render_frame_host->render_view_host()) {
+ if (iter != render_view_host_map_.end() && iter->second == render_view_host) {
// Decrement the refcount and shutdown the RenderViewHost if no one else is
// using it.
CHECK_GT(iter->second->ref_count(), 0);
@@ -340,16 +338,15 @@ void FrameTree::UnregisterRenderFrameHost(
for (RenderViewHostMultiMap::iterator multi_iter = result.first;
multi_iter != result.second;
++multi_iter) {
- if (multi_iter->second != render_frame_host->render_view_host())
+ if (multi_iter->second != render_view_host)
continue;
render_view_host_found = true;
- RenderViewHostImpl* rvh = multi_iter->second;
// Decrement the refcount and shutdown the RenderViewHost if no one else
// is using it.
- CHECK_GT(rvh->ref_count(), 0);
- rvh->decrement_ref_count();
- if (rvh->ref_count() == 0) {
- rvh->Shutdown();
+ CHECK_GT(render_view_host->ref_count(), 0);
+ render_view_host->decrement_ref_count();
+ if (render_view_host->ref_count() == 0) {
+ render_view_host->Shutdown();
render_view_host_pending_shutdown_map_.erase(multi_iter);
}
break;
« no previous file with comments | « content/browser/frame_host/frame_tree.h ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698