Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index fb0e869c0bde15ba60163c3aeffa0bcca0412dac..9f6fea2955df5216f47ed7a02305300fea970ae7 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -555,7 +555,9 @@ bool PasswordManager::CanProvisionalManagerSave() {
bool PasswordManager::ShouldPromptUserToSavePassword() const {
return !client_->IsAutomaticPasswordSavingEnabled() &&
- provisional_save_manager_->IsNewLogin() &&
+ (provisional_save_manager_->IsNewLogin() ||
+ provisional_save_manager_->observed_form()
+ .IsPossibleChangePasswordFormWithoutUsername()) &&
!provisional_save_manager_->has_generated_password() &&
!provisional_save_manager_->IsPendingCredentialsPublicSuffixMatch();
}
@@ -687,9 +689,13 @@ void PasswordManager::OnLoginSuccessful() {
empty_password);
if (logger)
logger->LogMessage(Logger::STRING_DECISION_ASK);
- if (client_->PromptUserToSavePassword(
+ bool update_password = !provisional_save_manager_->best_matches().empty() &&
+ provisional_save_manager_->observed_form()
+ .IsPossibleChangePasswordFormWithoutUsername();
+ if (client_->PromptUserToSaveOrUpdatePassword(
provisional_save_manager_.Pass(),
- CredentialSourceType::CREDENTIAL_SOURCE_PASSWORD_MANAGER)) {
+ CredentialSourceType::CREDENTIAL_SOURCE_PASSWORD_MANAGER,
+ update_password)) {
if (logger)
logger->LogMessage(Logger::STRING_SHOW_PASSWORD_PROMPT);
}

Powered by Google App Engine
This is Rietveld 408576698