Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 85463da1e38284228c54396c53eb93af737c972c..20255ee66a1c7f4a1f53bf63eb59f2f94a7e3d8b 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -145,6 +145,11 @@ class PasswordFormManager : public PasswordStoreConsumer {
// TODO: Make this private once we switch to the new UI.
void Save();
+ // Update the password store entry for |credentials_to_update|, using the
+ // password from |pending_credentials_|. It modifies |pending_credentials_|.
+ // |credentials_to_update| should be one of |best_matches_|.
+ void Update(const autofill::PasswordForm& credentials_to_update);
+
// Call these if/when we know the form submission worked or failed.
// These routines are used to update internal statistics ("ActionsTaken").
void SubmitPassed();
@@ -355,6 +360,13 @@ class PasswordFormManager : public PasswordStoreConsumer {
// from password store.
void CreatePendingCredentials();
+ // If |best_matches| contains only one entry then return this entry. Otherwise
+ // for empty |password| return nullptr and for non-empty |password| returns
+ // the unique entry in |best_matches_| with the same password, if it exists,
+ // and nullptr otherwise.
+ autofill::PasswordForm* FindBestMatchForUpdatePassword(
+ const base::string16& password) const;
+
// Set of PasswordForms from the DB that best match the form
// being managed by this. Use a map instead of vector, because we most
// frequently require lookups by username value in IsNewLogin.

Powered by Google App Engine
This is Rietveld 408576698