Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5442)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
index 82d3bb6c36d461cff6ada49c9baab83535fdf42d..594740acaa4148915335c21aa970b31aaca74727 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.h
@@ -41,6 +41,13 @@ class ManagePasswordsUIController
void OnPasswordSubmitted(
scoped_ptr<password_manager::PasswordFormManager> form_manager);
+ // Called when the user submits a change password form, so we can handle
+ // later requests to update stored credentials in the PasswordManager.
+ // This stores the provided object and triggers the UI to prompt the user
+ // about whether they would like to update the password.
+ void OnUpdatePasswordSubmitted(
+ scoped_ptr<password_manager::PasswordFormManager> form_manager);
+
// Called when the site asks user to choose from credentials. This triggers
// the UI to prompt the user. |local_credentials| and |federated_credentials|
// shouldn't both be empty.
@@ -76,10 +83,15 @@ class ManagePasswordsUIController
const password_manager::PasswordStoreChangeList& changes) override;
// Called from the model when the user chooses to save a password; passes the
- // action off to the FormManager. The controller MUST be in a pending state,
- // and WILL be in MANAGE_STATE after this method executes.
+ // action to the |form_manager|. The controller must be in a pending state,
+ // and will be in MANAGE_STATE after this method executes.
virtual void SavePassword();
+ // Called from the model when the user chooses to update a password; passes
+ // the action to the |form_manager|. The controller must be in a pending
+ // state, and will be in MANAGE_STATE after this method executes.
+ virtual void UpdatePassword(const autofill::PasswordForm& password_form);
+
// Called from the model when the user chooses a credential.
// The controller MUST be in a pending credentials state.
virtual void ChooseCredential(
@@ -151,6 +163,8 @@ class ManagePasswordsUIController
// The pieces of saving and blacklisting passwords that interact with
// FormManager, split off into internal functions for testing/mocking.
virtual void SavePasswordInternal();
+ virtual void UpdatePasswordInternal(
+ const autofill::PasswordForm& password_form);
virtual void NeverSavePasswordInternal();
// Called when a PasswordForm is autofilled, when a new PasswordForm is

Powered by Google App Engine
This is Rietveld 408576698