Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4821)

Unified Diff: chrome/browser/password_manager/password_manager_test_base.h

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_test_base.h
diff --git a/chrome/browser/password_manager/password_manager_test_base.h b/chrome/browser/password_manager/password_manager_test_base.h
index 44ce40bca940afb315b2cf4961b4295582c0cced..2a134ac98b5a7f375aea5cfea707687d9116486f 100644
--- a/chrome/browser/password_manager/password_manager_test_base.h
+++ b/chrome/browser/password_manager/password_manager_test_base.h
@@ -11,6 +11,10 @@
#include "content/public/browser/web_contents_observer.h"
#include "content/public/test/test_utils.h"
+namespace autofill {
+struct PasswordForm;
+}
+
class NavigationObserver : public content::WebContentsObserver {
public:
explicit NavigationObserver(content::WebContents* web_contents);
@@ -55,13 +59,20 @@ class PromptObserver {
public:
virtual ~PromptObserver();
- // Checks if the prompt is being currently shown.
+ // Checks if the save prompt is being currently shown.
virtual bool IsShowingPrompt() const = 0;
+ // Checks if the update prompt is being currently shown.
+ virtual bool IsShowingUpdatePrompt() const;
+
// Expecting that the prompt is shown, saves the password. Checks that the
// prompt is no longer visible afterwards.
void Accept() const;
+ // Expecting that the prompt is shown, update |form| with the password from
+ // observed form. Checks that the prompt is no longer visible afterwards.
+ void AcceptUpdatePrompt(const autofill::PasswordForm& form) const;
+
// Chooses the right implementation of PromptObserver and creates an instance
// of it.
static scoped_ptr<PromptObserver> Create(content::WebContents* web_contents);
@@ -74,6 +85,14 @@ class PromptObserver {
// closed.
virtual void AcceptImpl() const = 0;
+ // Accepts the password update. The implementation can assume that the prompt
+ // is currently shown, but is required to verify that the prompt is eventually
+ // closed.
+ // TODO(dvadym): Make this method pure virtual as soon as update UI is
+ // implemented for infobar. http://crbug.com/359315
+ virtual void AcceptUpdatePromptImpl(
+ const autofill::PasswordForm& form) const {}
+
private:
DISALLOW_COPY_AND_ASSIGN(PromptObserver);
};

Powered by Google App Engine
This is Rietveld 408576698