components/password_manager/core/browser/stub_password_manager_client.h - Issue 1151373006: Update Confirmation UI for saved password change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/stub_password_manager_client.h

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed reviewer comments and made showing new password in update bubble Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('K') | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/password_manager/core/browser/stub_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/stub_password_manager_client.h

diff --git a/components/password_manager/core/browser/stub_password_manager_client.h b/components/password_manager/core/browser/stub_password_manager_client.h

index 80d3bd3dcade9dd9210d101884894df13e9f2a6d..c887b32cd1ae3b9f6b3744a4c32a1af3b1c291bc 100644

--- a/components/password_manager/core/browser/stub_password_manager_client.h

+++ b/components/password_manager/core/browser/stub_password_manager_client.h

@@ -22,9 +22,10 @@ class StubPasswordManagerClient : public PasswordManagerClient {

bool IsSyncAccountCredential(const std::string& username,

const std::string& realm) const override;

bool ShouldFilterAutofillResult(const autofill::PasswordForm& form) override;

- bool PromptUserToSavePassword(

+ bool PromptUserToSaveOrUpdatePassword(

scoped_ptr<PasswordFormManager> form_to_save,

- password_manager::CredentialSourceType type) override;

+ password_manager::CredentialSourceType type,

+ bool update_password) override;

bool PromptUserToChooseCredentials(

ScopedVector<autofill::PasswordForm> local_forms,

ScopedVector<autofill::PasswordForm> federated_forms,