Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test fixes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
index 5478e0290e5928e06a5368a10d7739f10b748bc4..31171c76b4e8a04ce9cbaf8abf73fba4700bdd46 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
@@ -51,6 +51,8 @@ class TestManagePasswordsUIController : public ManagePasswordsUIController {
void UpdateBubbleAndIconVisibility() override;
void UpdateAndroidAccountChooserInfoBarVisibility() override;
void SavePasswordInternal() override {}
+ void UpdatePasswordInternal(
+ const autofill::PasswordForm& password_form) override {}
void NeverSavePasswordInternal() override;
base::TimeDelta elapsed_;
@@ -552,3 +554,30 @@ TEST_F(ManagePasswordsUIControllerTest, InactiveOnPSLMatched) {
EXPECT_EQ(password_manager::ui::INACTIVE_STATE, controller()->state());
}
+
+TEST_F(ManagePasswordsUIControllerTest, UpdatePasswordSubmitted) {
+ scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
+ CreateFormManager());
+ controller()->OnUpdatePasswordSubmitted(test_form_manager.Pass());
+ EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE,
+ controller()->state());
+
+ ManagePasswordsIconMock mock;
+ controller()->UpdateIconAndBubbleState(&mock);
+ EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE, mock.state());
+}
+
+TEST_F(ManagePasswordsUIControllerTest, PasswordUpdated) {
+ scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
+ CreateFormManager());
+ test_form_manager->ProvisionallySave(
+ test_local_form(),
+ password_manager::PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
+ controller()->OnUpdatePasswordSubmitted(test_form_manager.Pass());
+
+ ManagePasswordsIconMock mock;
+ controller()->UpdateIconAndBubbleState(&mock);
vasilii 2015/07/31 14:38:53 You need to check the mock state here or just remo
dvadym 2015/08/03 15:44:08 Done.
+ controller()->UpdatePassword(autofill::PasswordForm());
+ controller()->UpdateIconAndBubbleState(&mock);
+ EXPECT_EQ(password_manager::ui::MANAGE_STATE, mock.state());
+}

Powered by Google App Engine
This is Rietveld 408576698