components/password_manager/content/browser/credential_manager_dispatcher.cc - Issue 1151373006: Update Confirmation UI for saved password change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed reviewers' comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('K') | « components/autofill/core/common/password_form.cc ('k') | components/password_manager/core/browser/password_form_manager.h » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_dispatcher.cc

diff --git a/components/password_manager/content/browser/credential_manager_dispatcher.cc b/components/password_manager/content/browser/credential_manager_dispatcher.cc

index ab48d621f6dfdb2a80a13b661d3cc056e1b07664..3fee623da31c418d4d60a76023aaf0e463828743 100644

--- a/components/password_manager/content/browser/credential_manager_dispatcher.cc

+++ b/components/password_manager/content/browser/credential_manager_dispatcher.cc

@@ -78,8 +78,9 @@ void CredentialManagerDispatcher::OnProvisionalSaveComplete() {

DCHECK(form_manager_);

if (client_->IsSavingEnabledForCurrentPage() &&

!form_manager_->IsBlacklisted()) {

- client_->PromptUserToSavePassword(

- form_manager_.Pass(), CredentialSourceType::CREDENTIAL_SOURCE_API);

+ client_->PromptUserToSaveOrUpdatePassword(

+ form_manager_.Pass(), CredentialSourceType::CREDENTIAL_SOURCE_API,

+ false);

}