Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit test compilation error, updated comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 9dc40889f709fbeffe100a265d661cdc77244280..4d2146f11923e2adecf2e6e80f2aba19b54253a0 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -145,6 +145,10 @@ class PasswordFormManager : public PasswordStoreConsumer {
// TODO: Make this private once we switch to the new UI.
void Save();
+ // Update the password store entry for |credentials_to_update|, using the
+ // password from |pending_credentials_|.
vasilii 2015/07/23 15:15:13 Mention that it modifies |pending_credentials_| as
dvadym 2015/07/24 16:42:40 Done.
+ void Update(const autofill::PasswordForm& credentials_to_update);
+
// Call these if/when we know the form submission worked or failed.
// These routines are used to update internal statistics ("ActionsTaken").
void SubmitPassed();
@@ -338,6 +342,13 @@ class PasswordFormManager : public PasswordStoreConsumer {
// from password store.
void CreatePendingCredentials();
+ // For non-empty |password| returns the unique entry in |best_matches_| with
+ // the same password, if it exists, and nullptr otherwise. For empty
+ // |password|, if there is just one entry in |best_matches_| , returns that
vabr (Chromium) 2015/07/24 08:24:29 nit: No space before ",".
dvadym 2015/07/24 16:42:40 Done.
+ // entry, otherwise nullptr.
+ autofill::PasswordForm* FindBestMatchForUpdatePassword(
+ const base::string16& password);
+
// Set of PasswordForms from the DB that best match the form
// being managed by this. Use a map instead of vector, because we most
// frequently require lookups by username value in IsNewLogin.

Powered by Google App Engine
This is Rietveld 408576698