chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc - Issue 1151373006: Update Confirmation UI for saved password change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed unit test compilation error, updated comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/passwords/manage_passwords_view_utils.h ('K') | « chrome/browser/ui/passwords/manage_passwords_view_utils.cc ('k') | chrome/browser/ui/views/passwords/credentials_selection_view.h » ('j') | chrome/browser/ui/views/passwords/credentials_selection_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

index c02b0ae9229a084556f82351c2da814403cce383..1e433c7aeca46579f1c9b5cf7a15e4186fcd7fd3 100644

--- a/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_view_utils_unittest.cc

@@ -62,7 +62,8 @@ TEST(ManagePasswordsViewUtilTest, GetSavePasswordDialogTitleTextAndLinkRange) {

GetSavePasswordDialogTitleTextAndLinkRange(

GURL(test_cases[i].user_visible_url),

GURL(test_cases[i].form_origin_url),

- test_cases[i].is_smartlock_branding_enabled, &title, &title_link_range);

+ test_cases[i].is_smartlock_branding_enabled, false, &title,

vasilii 2015/07/23 15:15:13 The true value would be also nice to test.

dvadym 2015/07/24 16:42:39 Sure, the tests will be in next PatchSets

+ &title_link_range);

// Verify against expectations.

EXPECT_TRUE(base::EndsWith(