Update Confirmation UI for saved password change

components/autofill/core/common/password_form.h

Index: components/autofill/core/common/password_form.h
diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h
index 96633264b01e32a407cdf3e9d150ee763faad6f0..6d97c0f3fb72a09b393b6c5bbb4ba81a019af8a5 100644
--- a/components/autofill/core/common/password_form.h
+++ b/components/autofill/core/common/password_form.h
@@ -268,6 +268,10 @@ struct PasswordForm {
   // TODO(vabr): Remove |is_alive| once http://crbug.com/486931 is fixed.
   bool is_alive;  // Set on construction, reset on destruction.
 
+  // If true, then this form is considered to be a password change form without

[vabr (Chromium), 2015/06/19 18:03:16]

The comments should add value. All the information of these two lines is already
in the variable name. But it would be perhaps useful to note that this is only
used on the browser side, for communicating with the UI.

Such information is not apparent, and might explain, why this flag is not
preserved by IPC serialisation.

[dvadym, 2015/07/23 09:45:43]

This variable was removed

+  // username field.
+  bool is_password_change_form_without_username;

[vabr (Chromium), 2015/06/19 18:03:16]

I'm not thrilled about adding a new field to PasswordForm just to use it to
communicate between PasswordManager and the UI.

http://crbug.com/498048 already lists 3 usages of PasswordForm, and the need to
split the struct. This is a 4th type.

It would be great if you could instead keep and pass this information separately
only when it is needed, so that the unused variable is not hauled along in all
renderer code, and stored in the password store.

+
   // Returns true if this match was found using public suffix matching.
   bool IsPublicSuffixMatch() const;