Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5907)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed reviewer comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index 16e0dcb359354c06cbc778c5e6eaa46e7fe87872..e644f7992b7748e62cc438f1dc0b42df3d34147e 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -63,9 +63,12 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// Called by the view code when the site is unblacklisted.
void OnUnblacklistClicked();
- // Called by the view code when the save button in clicked by the user.
+ // Called by the view code when the save button is clicked by the user.
void OnSaveClicked();
+ // Called by the view code when the update link is clicked by the user.
+ void OnUpdateClicked(const autofill::PasswordForm& password_form);
+
// Called by the view code when the "Done" button is clicked by the user.
void OnDoneClicked();
@@ -100,6 +103,7 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
password_manager::ui::State state() const { return state_; }
const base::string16& title() const { return title_; }
+ const base::string16& save_button_text() const { return save_button_text_; }
const autofill::PasswordForm& pending_password() const {
return pending_password_;
}
@@ -126,12 +130,20 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
return title_brand_link_range_;
}
+ bool is_password_change_form_without_username() const {
+ return pending_password_.is_password_change_form_without_username;
+ }
+
Profile* GetProfile() const;
// Returns true iff the new UI should be presented to user for managing and
// saving the passwords.
bool IsNewUIActive() const;
+ // Returns true iff the multiple account selection prompt for account update
+ // should be presented.
+ bool ShouldShowMultipleAccountUpdateUI() const;
+
#if defined(UNIT_TEST)
// Gets and sets the reason the bubble was displayed.
password_manager::metrics_util::UIDisplayDisposition display_disposition()
@@ -160,6 +172,7 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
GURL origin_;
password_manager::ui::State state_;
base::string16 title_;
+ base::string16 save_button_text_;
// Range of characters in the title that contains the Smart Lock Brand and
// should point to an article. For the default title the range is empty.
gfx::Range title_brand_link_range_;

Powered by Google App Engine
This is Rietveld 408576698