Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Side by Side Diff: chrome/browser/password_manager/save_password_infobar_delegate.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/save_password_infobar_delegate.h" 5 #include "chrome/browser/password_manager/save_password_infobar_delegate.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "chrome/browser/infobars/infobar_service.h" 8 #include "chrome/browser/infobars/infobar_service.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/sync/profile_sync_service.h" 10 #include "chrome/browser/sync/profile_sync_service.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 uma_histogram_suffix_(uma_histogram_suffix), 84 uma_histogram_suffix_(uma_histogram_suffix),
85 source_type_(source_type) { 85 source_type_(source_type) {
86 if (!uma_histogram_suffix_.empty()) { 86 if (!uma_histogram_suffix_.empty()) {
87 password_manager::metrics_util::LogUMAHistogramBoolean( 87 password_manager::metrics_util::LogUMAHistogramBoolean(
88 "PasswordManager.SavePasswordPromptDisplayed_" + uma_histogram_suffix_, 88 "PasswordManager.SavePasswordPromptDisplayed_" + uma_histogram_suffix_,
89 true); 89 true);
90 } 90 }
91 title_link_range_ = gfx::Range(); 91 title_link_range_ = gfx::Range();
92 GetSavePasswordDialogTitleTextAndLinkRange( 92 GetSavePasswordDialogTitleTextAndLinkRange(
93 web_contents->GetVisibleURL(), form_to_save_->observed_form().origin, 93 web_contents->GetVisibleURL(), form_to_save_->observed_form().origin,
94 is_smartlock_branding_enabled, &title_, &title_link_range_); 94 is_smartlock_branding_enabled, false, &title_, &title_link_range_);
95 } 95 }
96 96
97 infobars::InfoBarDelegate::Type 97 infobars::InfoBarDelegate::Type
98 SavePasswordInfoBarDelegate::GetInfoBarType() const { 98 SavePasswordInfoBarDelegate::GetInfoBarType() const {
99 return PAGE_ACTION_TYPE; 99 return PAGE_ACTION_TYPE;
100 } 100 }
101 101
102 infobars::InfoBarDelegate::InfoBarAutomationType 102 infobars::InfoBarDelegate::InfoBarAutomationType
103 SavePasswordInfoBarDelegate::GetInfoBarAutomationType() const { 103 SavePasswordInfoBarDelegate::GetInfoBarAutomationType() const {
104 return PASSWORD_INFOBAR; 104 return PASSWORD_INFOBAR;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 WindowOpenDisposition disposition) { 152 WindowOpenDisposition disposition) {
153 InfoBarService::WebContentsFromInfoBar(infobar()) 153 InfoBarService::WebContentsFromInfoBar(infobar())
154 ->OpenURL(content::OpenURLParams( 154 ->OpenURL(content::OpenURLParams(
155 GURL(l10n_util::GetStringUTF16( 155 GURL(l10n_util::GetStringUTF16(
156 IDS_PASSWORD_MANAGER_SMART_LOCK_PAGE)), 156 IDS_PASSWORD_MANAGER_SMART_LOCK_PAGE)),
157 content::Referrer(), 157 content::Referrer(),
158 (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition, 158 (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
159 ui::PAGE_TRANSITION_LINK, false)); 159 ui::PAGE_TRANSITION_LINK, false));
160 return true; 160 return true;
161 } 161 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698