Update Confirmation UI for saved password change

chrome/browser/ui/passwords/manage_passwords_bubble_model.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 
 #include "base/memory/scoped_vector.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"
 #include "components/autofill/core/common/password_form.h"
@@ skipping 45 matching lines @@
   // by the user.
   void OnNeverForThisSiteClicked();
 
   // Called by the view code when the "Undo" button is clicked in
   // "Never for this site." confirmation bubble by the user.
   void OnUndoNeverForThisSite();
 
   // Called by the view code when the site is unblacklisted.
   void OnUnblacklistClicked();
 
-  // Called by the view code when the save button in clicked by the user.
+  // Called by the view code when the save button is clicked by the user.
   void OnSaveClicked();
 
+  // Called by the view code when the update link is clicked by the user.
+  void OnUpdateClicked(const autofill::PasswordForm& password_form);
+
   // Called by the view code when the "Done" button is clicked by the user.
   void OnDoneClicked();
 
   // Called by the view code when the "OK" button is clicked by the user.
   void OnOKClicked();
 
   // Called by the view code when the manage link is clicked by the user.
   void OnManageLinkClicked();
 
   // Called by the view code when the brand name link is clicked by the user.
@@ skipping 14 matching lines @@
 
   // Called by the view code to notify about chosen credential.
   void OnChooseCredentials(const autofill::PasswordForm& password_form,
                            password_manager::CredentialType credential_type_);
 
   GURL origin() const { return origin_; }
 
   password_manager::ui::State state() const { return state_; }
 
   const base::string16& title() const { return title_; }
+  const base::string16& save_button_text() const { return save_button_text_; }
   const autofill::PasswordForm& pending_password() const {
     return pending_password_;
   }
   // Returns the available credentials which match the current site.
   const ScopedVector<const autofill::PasswordForm>& local_credentials() const {
     return local_credentials_;
   }
   // Return the federated logins which may be used for logging in to the current
   // site.
   const ScopedVector<const autofill::PasswordForm>& federated_credentials()
       const {
     return federated_credentials_;
   }
   const base::string16& manage_link() const { return manage_link_; }
   bool never_save_passwords() const { return never_save_passwords_; }
   const base::string16& save_confirmation_text() const {
     return save_confirmation_text_;
   }
   const gfx::Range& save_confirmation_link_range() const {
     return save_confirmation_link_range_;
   }
 
   const gfx::Range& title_brand_link_range() const {
     return title_brand_link_range_;
   }
 
+  bool account_for_update_selection() const {

[vabr (Chromium), 2015/06/03 16:33:26]

nit: Please don't inline the definition of the method, and rename it in
CamelCase. This is no longer a simple accessor, and therefore cannot be inlined
and named in hacker_style.

[vabr (Chromium), 2015/06/03 16:33:26]

Also, the name sounds a little cryptic (I'm not sure what it means). Would you
mind rephrasing it?

[vasilii, 2015/06/03 18:32:02]

I suppose it should be something like "ShouldShowMultipleAccountUpdateUI".
Please add a comment to the method.

[dvadym, 2015/06/19 15:27:29]

Thanks, it was temporary name from early prototyping. I changed name for
ShouldShowMultipleAccountUpdateUI and added comment "Returns true iff the
multiple account selection prompt for account update should be presented."

+    return pending_password_.is_password_change_form_without_username &&
+           local_credentials_.size() > 1;
+  }
+
+  bool is_password_change_form_without_username() const {
+    return pending_password_.is_password_change_form_without_username;
+  }
+
   Profile* GetProfile() const;
 
   // Returns true iff the new UI should be presented to user for managing and
   // saving the passwords.
   bool IsNewUIActive() const;
 
 #if defined(UNIT_TEST)
   // Gets and sets the reason the bubble was displayed.
   password_manager::metrics_util::UIDisplayDisposition display_disposition()
       const {
@@ skipping 14 matching lines @@
   static int PasswordFieldWidth();
 
  private:
   // Updates |title_| and |title_brand_link_range_| for the
   // PENDING_PASSWORD_STATE.
   void UpdatePendingStateTitle();
   // URL of the page from where this bubble was triggered.
   GURL origin_;
   password_manager::ui::State state_;
   base::string16 title_;
+  base::string16 save_button_text_;
   // Range of characters in the title that contains the Smart Lock Brand and
   // should point to an article. For the default title the range is empty.
   gfx::Range title_brand_link_range_;
   autofill::PasswordForm pending_password_;
   ScopedVector<const autofill::PasswordForm> local_credentials_;
   ScopedVector<const autofill::PasswordForm> federated_credentials_;
   base::string16 manage_link_;
   base::string16 save_confirmation_text_;
   gfx::Range save_confirmation_link_range_;
   // If true upon destruction, the user has confirmed that she never wants to
   // save passwords for a particular site.
   bool never_save_passwords_;
   password_manager::metrics_util::UIDisplayDisposition display_disposition_;
   password_manager::metrics_util::UIDismissalReason dismissal_reason_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleModel);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_