Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_state.cc

Issue 1151373006: Update Confirmation UI for saved password change (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit test compilation error, updated comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/manage_passwords_state.h" 5 #include "chrome/browser/ui/passwords/manage_passwords_state.h"
6 6
7 #include "components/password_manager/core/browser/browser_save_password_progres s_logger.h" 7 #include "components/password_manager/core/browser/browser_save_password_progres s_logger.h"
8 #include "components/password_manager/core/browser/password_form_manager.h" 8 #include "components/password_manager/core/browser/password_form_manager.h"
9 #include "components/password_manager/core/browser/password_manager_client.h" 9 #include "components/password_manager/core/browser/password_manager_client.h"
10 #include "components/password_manager/core/common/credential_manager_types.h" 10 #include "components/password_manager/core/common/credential_manager_types.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 } 113 }
114 114
115 ManagePasswordsState::~ManagePasswordsState() {} 115 ManagePasswordsState::~ManagePasswordsState() {}
116 116
117 void ManagePasswordsState::OnPendingPassword( 117 void ManagePasswordsState::OnPendingPassword(
118 scoped_ptr<password_manager::PasswordFormManager> form_manager) { 118 scoped_ptr<password_manager::PasswordFormManager> form_manager) {
119 ClearData(); 119 ClearData();
120 form_manager_ = form_manager.Pass(); 120 form_manager_ = form_manager.Pass();
121 current_forms_weak_ = ScopedPtrMapToVector(form_manager_->best_matches()); 121 current_forms_weak_ = ScopedPtrMapToVector(form_manager_->best_matches());
122 origin_ = form_manager_->pending_credentials().origin; 122 origin_ = form_manager_->pending_credentials().origin;
123 SetState(password_manager::ui::PENDING_PASSWORD_STATE); 123 if (client_->IsUpdatePasswordUIEnabled() &&
124 form_manager_->observed_form()
125 .IsPossibleChangePasswordFormWithoutUsername()) {
vasilii 2015/07/23 15:15:13 This doesn't belong here. PasswordFormManager shou
dvadym 2015/07/24 16:42:39 Done.
126 SetState(password_manager::ui::PENDING_PASSWORD_UPDATE_STATE);
127 } else {
128 SetState(password_manager::ui::PENDING_PASSWORD_STATE);
129 }
124 } 130 }
125 131
126 void ManagePasswordsState::OnRequestCredentials( 132 void ManagePasswordsState::OnRequestCredentials(
127 ScopedVector<autofill::PasswordForm> local_credentials, 133 ScopedVector<autofill::PasswordForm> local_credentials,
128 ScopedVector<autofill::PasswordForm> federated_credentials, 134 ScopedVector<autofill::PasswordForm> federated_credentials,
129 const GURL& origin) { 135 const GURL& origin) {
130 ClearData(); 136 ClearData();
131 local_credentials_forms_ = ConstifyVector(&local_credentials); 137 local_credentials_forms_ = ConstifyVector(&local_credentials);
132 federated_credentials_forms_ = ConstifyVector(&federated_credentials); 138 federated_credentials_forms_ = ConstifyVector(&federated_credentials);
133 origin_ = origin; 139 origin_ = origin;
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 void ManagePasswordsState::SetState(password_manager::ui::State state) { 282 void ManagePasswordsState::SetState(password_manager::ui::State state) {
277 DCHECK(client_); 283 DCHECK(client_);
278 if (client_->IsLoggingActive()) { 284 if (client_->IsLoggingActive()) {
279 password_manager::BrowserSavePasswordProgressLogger logger(client_); 285 password_manager::BrowserSavePasswordProgressLogger logger(client_);
280 logger.LogNumber( 286 logger.LogNumber(
281 autofill::SavePasswordProgressLogger::STRING_NEW_UI_STATE, 287 autofill::SavePasswordProgressLogger::STRING_NEW_UI_STATE,
282 state); 288 state);
283 } 289 }
284 state_ = state; 290 state_ = state;
285 } 291 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698