Issue 1151373002: Fixed a couple of failing DCHECK(has_pending_exception()).

Issue 1151373002: Fixed a couple of failing DCHECK(has_pending_exception()). (Closed)

Created:
5 years, 7 months ago by Igor Sheludko

Modified:
5 years, 7 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fixed a couple of failing DCHECK(has_pending_exception()). BUG=chromium:491062 LOG=N Committed: https://crrev.com/62b56507cce3c57a2e1aebce6d34f29b3b64e762 Cr-Commit-Position: refs/heads/master@{#28617}

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -11 lines)			Patch
M	src/debug.cc	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	src/runtime/runtime-debug.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-491062.js	View	1 chunk	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151373002/1

5 years, 7 months ago (2015-05-26 09:44:31 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/62b56507cce3c57a2e1aebce6d34f29b3b64e762 Cr-Commit-Position: refs/heads/master@{#28617}

5 years, 7 months ago (2015-05-26 10:07:00 UTC) #7

Igor Sheludko

5 years, 7 months ago (2015-05-26 10:28:00 UTC) #8

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1148423004/ by ishell@chromium.org.

The reason for reverting is: Broke V8 Linux - nosnap..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages