Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1151353005: Use the exact-width integer types defined in <stdint.h> rather than (Closed)

Created:
5 years, 6 months ago by wtc
Modified:
5 years, 6 months ago
Reviewers:
asanka
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the exact-width integer types defined in <stdint.h> rather than "base/basictypes.h" in net/base/mime_sniffer*. R=asanka@chromium.org BUG=488550 TEST=none Committed: https://crrev.com/e2a366743c9b1b511cbcc9e30cd5ab3b8860f070 Cr-Commit-Position: refs/heads/master@{#333098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M net/base/mime_sniffer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/mime_sniffer_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_sniffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
wtc
5 years, 6 months ago (2015-06-03 21:12:50 UTC) #1
asanka
lgtm
5 years, 6 months ago (2015-06-04 20:06:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151353005/1
5 years, 6 months ago (2015-06-04 20:29:54 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/94853)
5 years, 6 months ago (2015-06-04 21:45:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151353005/1
5 years, 6 months ago (2015-06-05 17:43:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 18:33:37 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 18:35:29 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2a366743c9b1b511cbcc9e30cd5ab3b8860f070
Cr-Commit-Position: refs/heads/master@{#333098}

Powered by Google App Engine
This is Rietveld 408576698