Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.cc

Issue 1151353003: [scheduler]: Avoid waking up the scheduler to end long idle periods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@end_idle_sync_2
Patch Set: Fix Win for realz hopefully... Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl.cc b/components/scheduler/renderer/renderer_scheduler_impl.cc
index 48c4c1b2228d3de8dd51845e05841d517f37a517..3b92680c1a309261a510b1eb113deabb00b9cb90 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl.cc
@@ -136,7 +136,7 @@ void RendererSchedulerImpl::DidCommitFrameToCompositor() {
// the next pending delayed tasks (as currently done in for long idle times)
idle_helper_.StartIdlePeriod(
IdleHelper::IdlePeriodState::IN_SHORT_IDLE_PERIOD, now,
- estimated_next_frame_begin_, true);
+ estimated_next_frame_begin_);
}
}
@@ -304,9 +304,7 @@ bool RendererSchedulerImpl::ShouldYieldForHighPriorityWork() {
base::TimeTicks RendererSchedulerImpl::CurrentIdleTaskDeadlineForTesting()
const {
- base::TimeTicks deadline;
- idle_helper_.CurrentIdleTaskDeadlineCallback(&deadline);
- return deadline;
+ return idle_helper_.CurrentIdleTaskDeadline();
}
RendererSchedulerImpl::Policy RendererSchedulerImpl::SchedulerPolicy() const {
@@ -487,24 +485,6 @@ SchedulerHelper* RendererSchedulerImpl::GetSchedulerHelperForTesting() {
return &helper_;
}
-RendererSchedulerImpl::PollableNeedsUpdateFlag::PollableNeedsUpdateFlag(
- base::Lock* write_lock_)
- : flag_(false), write_lock_(write_lock_) {
-}
-
-RendererSchedulerImpl::PollableNeedsUpdateFlag::~PollableNeedsUpdateFlag() {
-}
-
-void RendererSchedulerImpl::PollableNeedsUpdateFlag::SetWhileLocked(
- bool value) {
- write_lock_->AssertAcquired();
- base::subtle::Release_Store(&flag_, value);
-}
-
-bool RendererSchedulerImpl::PollableNeedsUpdateFlag::IsSet() const {
- return base::subtle::Acquire_Load(&flag_) != 0;
-}
-
void RendererSchedulerImpl::SuspendTimerQueue() {
helper_.CheckOnValidThread();
timer_queue_suspend_count_++;

Powered by Google App Engine
This is Rietveld 408576698