components/scheduler/child/task_queue_manager.cc - Issue 1151353003: [scheduler]: Avoid waking up the scheduler to end long idle periods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/child/task_queue_manager.cc

Issue 1151353003: [scheduler]: Avoid waking up the scheduler to end long idle periods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@end_idle_sync_2

Patch Set: Fix tests and update for review. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/child/idle_helper.cc ('K') | « components/scheduler/child/single_thread_idle_task_runner.cc ('k') | components/scheduler/child/worker_scheduler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/child/task_queue_manager.cc

diff --git a/components/scheduler/child/task_queue_manager.cc b/components/scheduler/child/task_queue_manager.cc

index 366c682d081e74b3e78725bb64342832b039a687..d9fa47c9203ff6e4da49dc4f2ffb8e9eb088bad5 100644

--- a/components/scheduler/child/task_queue_manager.cc

+++ b/components/scheduler/child/task_queue_manager.cc

@@ -712,14 +712,14 @@ void TaskQueueManager::SetWorkBatchSize(int work_batch_size) {

void TaskQueueManager::AddTaskObserver(

base::MessageLoop::TaskObserver* task_observer) {

DCHECK(main_thread_checker_.CalledOnValidThread());

- base::MessageLoop::current()->AddTaskObserver(task_observer);

+ main_task_runner_->AddTaskObserver(task_observer);

task_observers_.AddObserver(task_observer);

}

void TaskQueueManager::RemoveTaskObserver(

base::MessageLoop::TaskObserver* task_observer) {

DCHECK(main_thread_checker_.CalledOnValidThread());

- base::MessageLoop::current()->RemoveTaskObserver(task_observer);

+ main_task_runner_->RemoveTaskObserver(task_observer);

task_observers_.RemoveObserver(task_observer);

}