components/scheduler/child/nestable_single_thread_task_runner.h - Issue 1151353003: [scheduler]: Avoid waking up the scheduler to end long idle periods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/scheduler/child/nestable_single_thread_task_runner.h

Issue 1151353003: [scheduler]: Avoid waking up the scheduler to end long idle periods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@end_idle_sync_2

Patch Set: Fix tests and update for review. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/scheduler/child/idle_helper.cc ('K') | « components/scheduler/child/idle_helper_unittest.cc ('k') | components/scheduler/child/nestable_task_runner_for_test.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/scheduler/child/nestable_single_thread_task_runner.h

diff --git a/components/scheduler/child/nestable_single_thread_task_runner.h b/components/scheduler/child/nestable_single_thread_task_runner.h

index e1bf99094da241978c993eb2b53eaf4284c66c65..0b507a2d254efcb5657c320d5f867fd70679bf80 100644

--- a/components/scheduler/child/nestable_single_thread_task_runner.h

+++ b/components/scheduler/child/nestable_single_thread_task_runner.h

@@ -6,6 +6,7 @@

#define COMPONENTS_SCHEDULER_CHILD_NESTABLE_SINGLE_THREAD_TASK_RUNNER_H_

#include "base/single_thread_task_runner.h"

+#include "base/message_loop/message_loop.h"

#include "components/scheduler/scheduler_export.h"

namespace scheduler {

@@ -20,6 +21,12 @@ class SCHEDULER_EXPORT NestableSingleThreadTaskRunner

// a nested task).

virtual bool IsNested() const = 0;

+ // Adds and removes MessageLoop::TaskObservers to the task runner.

+ virtual void AddTaskObserver(

+ base::MessageLoop::TaskObserver* task_observer) = 0;

+ virtual void RemoveTaskObserver(

+ base::MessageLoop::TaskObserver* task_observer) = 0;

protected:

~NestableSingleThreadTaskRunner() override {}