Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Side by Side Diff: components/scheduler/child/single_thread_idle_task_runner.cc

Issue 1151353003: [scheduler]: Avoid waking up the scheduler to end long idle periods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@end_idle_sync_2
Patch Set: Fix Win for realz hopefully... Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/child/single_thread_idle_task_runner.h" 5 #include "components/scheduler/child/single_thread_idle_task_runner.h"
6 6
7 #include "base/location.h" 7 #include "base/location.h"
8 #include "base/trace_event/trace_event.h" 8 #include "base/trace_event/trace_event.h"
9 9
10 namespace scheduler { 10 namespace scheduler {
11 11
12 SingleThreadIdleTaskRunner::SingleThreadIdleTaskRunner( 12 SingleThreadIdleTaskRunner::SingleThreadIdleTaskRunner(
13 scoped_refptr<base::SingleThreadTaskRunner> idle_priority_task_runner, 13 scoped_refptr<base::SingleThreadTaskRunner> idle_priority_task_runner,
14 scoped_refptr<base::SingleThreadTaskRunner> after_wakeup_task_runner, 14 scoped_refptr<base::SingleThreadTaskRunner> after_wakeup_task_runner,
15 base::Callback<void(base::TimeTicks*)> deadline_supplier, 15 Delegate* delegate,
16 const char* tracing_category) 16 const char* tracing_category)
17 : idle_priority_task_runner_(idle_priority_task_runner), 17 : idle_priority_task_runner_(idle_priority_task_runner),
18 after_wakeup_task_runner_(after_wakeup_task_runner), 18 after_wakeup_task_runner_(after_wakeup_task_runner),
19 deadline_supplier_(deadline_supplier), 19 delegate_(delegate),
20 tracing_category_(tracing_category), 20 tracing_category_(tracing_category),
21 weak_factory_(this) { 21 weak_factory_(this) {
22 DCHECK(!idle_priority_task_runner_ || 22 DCHECK(!idle_priority_task_runner_ ||
23 idle_priority_task_runner_->RunsTasksOnCurrentThread()); 23 idle_priority_task_runner_->RunsTasksOnCurrentThread());
24 DCHECK(!after_wakeup_task_runner_ || 24 DCHECK(!after_wakeup_task_runner_ ||
25 after_wakeup_task_runner_->RunsTasksOnCurrentThread()); 25 after_wakeup_task_runner_->RunsTasksOnCurrentThread());
26 weak_scheduler_ptr_ = weak_factory_.GetWeakPtr(); 26 weak_scheduler_ptr_ = weak_factory_.GetWeakPtr();
27 } 27 }
28 28
29 SingleThreadIdleTaskRunner::~SingleThreadIdleTaskRunner() { 29 SingleThreadIdleTaskRunner::~SingleThreadIdleTaskRunner() {
30 } 30 }
31 31
32 SingleThreadIdleTaskRunner::Delegate::Delegate() {
33 }
34
35 SingleThreadIdleTaskRunner::Delegate::~Delegate() {
36 }
37
32 bool SingleThreadIdleTaskRunner::RunsTasksOnCurrentThread() const { 38 bool SingleThreadIdleTaskRunner::RunsTasksOnCurrentThread() const {
33 return idle_priority_task_runner_->RunsTasksOnCurrentThread(); 39 return idle_priority_task_runner_->RunsTasksOnCurrentThread();
34 } 40 }
35 41
36 void SingleThreadIdleTaskRunner::PostIdleTask( 42 void SingleThreadIdleTaskRunner::PostIdleTask(
37 const tracked_objects::Location& from_here, 43 const tracked_objects::Location& from_here,
38 const IdleTask& idle_task) { 44 const IdleTask& idle_task) {
45 delegate_->OnIdleTaskPosted();
39 idle_priority_task_runner_->PostTask( 46 idle_priority_task_runner_->PostTask(
40 from_here, base::Bind(&SingleThreadIdleTaskRunner::RunTask, 47 from_here, base::Bind(&SingleThreadIdleTaskRunner::RunTask,
41 weak_scheduler_ptr_, idle_task)); 48 weak_scheduler_ptr_, idle_task));
42 } 49 }
43 50
44 void SingleThreadIdleTaskRunner::PostNonNestableIdleTask( 51 void SingleThreadIdleTaskRunner::PostNonNestableIdleTask(
45 const tracked_objects::Location& from_here, 52 const tracked_objects::Location& from_here,
46 const IdleTask& idle_task) { 53 const IdleTask& idle_task) {
54 delegate_->OnIdleTaskPosted();
47 idle_priority_task_runner_->PostNonNestableTask( 55 idle_priority_task_runner_->PostNonNestableTask(
48 from_here, base::Bind(&SingleThreadIdleTaskRunner::RunTask, 56 from_here, base::Bind(&SingleThreadIdleTaskRunner::RunTask,
49 weak_scheduler_ptr_, idle_task)); 57 weak_scheduler_ptr_, idle_task));
50 } 58 }
51 59
52 void SingleThreadIdleTaskRunner::PostIdleTaskAfterWakeup( 60 void SingleThreadIdleTaskRunner::PostIdleTaskAfterWakeup(
53 const tracked_objects::Location& from_here, 61 const tracked_objects::Location& from_here,
54 const IdleTask& idle_task) { 62 const IdleTask& idle_task) {
63 // Don't signal posting of idle task to the delegate here, wait until the
64 // after-wakeup task posts the real idle task.
55 after_wakeup_task_runner_->PostTask( 65 after_wakeup_task_runner_->PostTask(
56 FROM_HERE, base::Bind(&SingleThreadIdleTaskRunner::PostIdleTask, 66 FROM_HERE, base::Bind(&SingleThreadIdleTaskRunner::PostIdleTask,
57 weak_scheduler_ptr_, from_here, idle_task)); 67 weak_scheduler_ptr_, from_here, idle_task));
58 } 68 }
59 69
60 void SingleThreadIdleTaskRunner::RunTask(IdleTask idle_task) { 70 void SingleThreadIdleTaskRunner::RunTask(IdleTask idle_task) {
61 base::TimeTicks deadline; 71 base::TimeTicks deadline = delegate_->WillProcessIdleTask();
62 deadline_supplier_.Run(&deadline);
63 TRACE_EVENT1(tracing_category_, "SingleThreadIdleTaskRunner::RunTask", 72 TRACE_EVENT1(tracing_category_, "SingleThreadIdleTaskRunner::RunTask",
64 "allotted_time_ms", 73 "allotted_time_ms",
65 (deadline - base::TimeTicks::Now()).InMillisecondsF()); 74 (deadline - base::TimeTicks::Now()).InMillisecondsF());
66 idle_task.Run(deadline); 75 idle_task.Run(deadline);
67 bool is_tracing; 76 delegate_->DidProcessIdleTask();
68 TRACE_EVENT_CATEGORY_GROUP_ENABLED(tracing_category_, &is_tracing);
69 if (is_tracing && base::TimeTicks::Now() > deadline) {
70 TRACE_EVENT_INSTANT0(tracing_category_,
71 "SingleThreadIdleTaskRunner::DidOverrunDeadline",
72 TRACE_EVENT_SCOPE_THREAD);
73 }
74 } 77 }
75 78
76 } // namespace scheduler 79 } // namespace scheduler
OLDNEW
« no previous file with comments | « components/scheduler/child/single_thread_idle_task_runner.h ('k') | components/scheduler/child/worker_scheduler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698