src/debug.cc - Issue 1151333005: A couple of other "stack overflow" vs. "has_pending_exception()" issues fixed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug.cc

Issue 1151333005: A couple of other "stack overflow" vs. "has_pending_exception()" issues fixed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebasing and try failures fixes Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug.cc

diff --git a/src/debug.cc b/src/debug.cc

index 9ba288581de8a10feeb1f07ee6014f6ec58d5c75..342aa505da7b6378f66f9636dfc3eef12ce3df1d 100644

--- a/src/debug.cc

+++ b/src/debug.cc

@@ -637,8 +637,8 @@ bool Debug::CompileDebuggerScript(Isolate* isolate, int index) {

if (maybe_exception.ToHandle(&exception)) {

isolate->set_pending_exception(*exception);

MessageHandler::ReportMessage(isolate, NULL, message);

- isolate->clear_pending_exception();

}

+ DCHECK(!maybe_exception.is_null());

return false;

}

« no previous file with comments | « src/d8.cc ('k') | src/isolate.cc » ('j') | no next file with comments »