Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1151333005: A couple of other "stack overflow" vs. "has_pending_exception()" issues fixed. (Closed)

Created:
5 years, 6 months ago by Igor Sheludko
Modified:
5 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

A couple of other "stack overflow" vs. "has_pending_exception()" issues fixed. BUG=chromium:471659, chromium:494158 LOG=N Committed: https://crrev.com/050e8880f51070e1db3c79bdce9ea33f6ca3042b Cr-Commit-Position: refs/heads/master@{#28816}

Patch Set 1 #

Patch Set 2 : More SO and tests fixes #

Patch Set 3 : Rebasing and try failures fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -30 lines) Patch
M src/bootstrapper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/d8.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/debug.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 1 chunk +14 lines, -8 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-450960.js View 1 1 chunk +6 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-471659.js View 1 1 chunk +8 lines, -8 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-491062.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Igor Sheludko
PTAL
5 years, 6 months ago (2015-06-03 16:45:22 UTC) #2
ulan
lgtm
5 years, 6 months ago (2015-06-05 15:22:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151333005/100001
5 years, 6 months ago (2015-06-05 15:50:05 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 6 months ago (2015-06-05 15:52:10 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 15:52:30 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/050e8880f51070e1db3c79bdce9ea33f6ca3042b
Cr-Commit-Position: refs/heads/master@{#28816}

Powered by Google App Engine
This is Rietveld 408576698