Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1151303008: Cleanup after TF super.prop (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk, brucedawson
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup after TF super.prop Assign null when declaring to ensure no branch can ever keep the value unassigned. BUG=N LOG=N R=adamk@chromium.org, brucedawson@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-08 17:58:49 UTC) #1
brucedawson
lgtm. Thanks for addressing this. The impetus for this, BTW, came from the /analyze builder. ...
5 years, 6 months ago (2015-06-08 18:03:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151303008/1
5 years, 6 months ago (2015-06-08 18:15:16 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-08 18:15:18 UTC) #6
brucedawson
I'm a full Chromium committer, but not a v8 committer.
5 years, 6 months ago (2015-06-08 18:18:55 UTC) #7
arv (Not doing code reviews)
Adam, care to take a quick look?
5 years, 6 months ago (2015-06-08 18:20:07 UTC) #9
arv (Not doing code reviews)
5 years, 6 months ago (2015-06-08 18:23:10 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698