tools/gn/docs/cookbook.md - Issue 1151303006: clang/win: Make everything work in a GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/docs/cookbook.md

Issue 1151303006: clang/win: Make everything work in a GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nacl fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/docs/cookbook.md

diff --git a/tools/gn/docs/cookbook.md b/tools/gn/docs/cookbook.md

index 57df03c94b3c0bc5cb1521c7ff56bce144c3ed87..9e9d58b735a510cb9830dd7ec0043495ab6b2cf0 100644

--- a/tools/gn/docs/cookbook.md

+++ b/tools/gn/docs/cookbook.md

@@ -484,8 +484,8 @@ compiler/BUILD.gn: "/wd4018", # Comparing signed and unsigned values.

```

tells us that warning 4018 is already disabled globally from the

-`//build/config/compiler:default_warnings` config, and the same for

-4244. So ignore these.

+`default_warning_flags` variable in `//build/config/compiler`, and the same

+for 4244. So ignore these.

Always comment what the warning is. Use your favorite search engine and

type "vc warning 4267" to look it up. You'll end up with:

« no previous file with comments | « third_party/mesa/BUILD.gn ('k') | no next file » | no next file with comments »