Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7514)

Unified Diff: chrome/common/extensions/docs/server2/datastore_models.py

Issue 1151283007: Docserver overhaul: Gitiles away from me. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove inform_users template to fix presubmit failure (it's now a redirect) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/datastore_models.py
diff --git a/chrome/common/extensions/docs/server2/datastore_models.py b/chrome/common/extensions/docs/server2/datastore_models.py
index c05a0b9151857cde76b48e5bf29534ec13f686a8..eaa8cab43a0be724b89cd8c32822e5c888852543 100644
--- a/chrome/common/extensions/docs/server2/datastore_models.py
+++ b/chrome/common/extensions/docs/server2/datastore_models.py
@@ -3,9 +3,13 @@
# found in the LICENSE file.
import cPickle
+import google.appengine.ext.db as db
+import logging
import traceback
-from appengine_wrappers import db
+
+_MAX_ENTITY_SIZE = 1024*1024
+
# A collection of the data store models used throughout the server.
# These values are global within datastore.
@@ -28,8 +32,13 @@ class PersistentObjectStoreItem(db.Model):
@classmethod
def CreateItem(cls, namespace, key, value):
+ pickled_value = cPickle.dumps(value)
+ if len(pickled_value) > _MAX_ENTITY_SIZE:
+ logging.warn('Refusing to create entity greater than 1 MB in size: %s/%s'
+ % (namespace, key))
+ return None
return PersistentObjectStoreItem(key=cls.CreateKey(namespace, key),
- pickled_value=cPickle.dumps(value))
+ pickled_value=pickled_value)
def GetValue(self):
return cPickle.loads(self.pickled_value)
« no previous file with comments | « chrome/common/extensions/docs/server2/data_source.py ('k') | chrome/common/extensions/docs/server2/datastore_util.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698