Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1151283003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions… (Closed)

Created:
5 years, 7 months ago by b.siddharth
Modified:
5 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions/browser/api/declarative_webrequest BUG=457697 Committed: https://crrev.com/841008bc45e957f1b07e7b84dd1e906914026265 Cr-Commit-Position: refs/heads/master@{#331285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
b.siddharth
Please have a look, Thanks.
5 years, 7 months ago (2015-05-22 06:12:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151283003/1
5 years, 7 months ago (2015-05-22 11:32:15 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-22 11:32:17 UTC) #6
Devlin
lgtm
5 years, 7 months ago (2015-05-22 16:22:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151283003/1
5 years, 7 months ago (2015-05-25 13:47:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-25 15:10:05 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-25 15:11:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/841008bc45e957f1b07e7b84dd1e906914026265
Cr-Commit-Position: refs/heads/master@{#331285}

Powered by Google App Engine
This is Rietveld 408576698