Issue 1151263014: chrome/settings: Use one-way data-binding in appearance_page.html for hidden attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1151263014: chrome/settings: Use one-way data-binding in appearance_page.html for hidden attribute. (Closed)

Created:
5 years, 6 months ago by James Hawkins

Modified:
5 years, 6 months ago

Reviewers:
Jeremy Klein

CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

chrome/settings: Use one-way data-binding in appearance_page.html for hidden attribute. R=jlklein@chromium.org BUG=none Committed: https://crrev.com/f2623309be01e2dfabb18aca0a7cad105bb3fbb9 Cr-Commit-Position: refs/heads/master@{#333055}

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/resources/settings/appearance_page/appearance_page.html	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

Committed patchset #2 (id:20001) manually as f2623309be01e2dfabb18aca0a7cad105bb3fbb9 (presubmit successful).

5 years, 6 months ago (2015-06-05 15:41:13 UTC) #3

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 15:41:18 UTC) #4

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/f2623309be01e2dfabb18aca0a7cad105bb3fbb9
Cr-Commit-Position: refs/heads/master@{#333055}

Expand Messages | Collapse Messages