Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1151263007: Devtools: Move animation to separate module (Closed)

Created:
5 years, 6 months ago by sergeyv
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, Eric Willigers, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Move animation to separate module BUG=462924 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -2244 lines) Patch
A + LayoutTests/inspector/animation/animation-timeline.html View 1 chunk +5 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/animation/animation-timeline-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/inspector/elements/animation-timeline.html View 1 chunk +0 lines, -94 lines 0 comments Download
D LayoutTests/inspector/elements/animation-timeline-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/inspector/initial-modules-load.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/initial-modules-load-expected.txt View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/devtools/devtools.gypi View 5 chunks +8 lines, -4 lines 0 comments Download
A + Source/devtools/front_end/animation/AnimationControlPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/devtools/front_end/animation/AnimationModel.js View 1 chunk +14 lines, -0 lines 0 comments Download
A + Source/devtools/front_end/animation/AnimationTimeline.js View 7 chunks +20 lines, -16 lines 0 comments Download
A + Source/devtools/front_end/animation/animationTimeline.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A Source/devtools/front_end/animation/module.json View 1 chunk +21 lines, -0 lines 0 comments Download
D Source/devtools/front_end/elements/AnimationControlPane.js View 1 chunk +0 lines, -151 lines 0 comments Download
D Source/devtools/front_end/elements/AnimationTimeline.js View 1 chunk +0 lines, -1148 lines 0 comments Download
M Source/devtools/front_end/elements/BezierUI.js View 3 chunks +4 lines, -2 lines 0 comments Download
D Source/devtools/front_end/elements/animationTimeline.css View 1 chunk +0 lines, -317 lines 0 comments Download
M Source/devtools/front_end/elements/module.json View 3 chunks +0 lines, -9 lines 0 comments Download
M Source/devtools/front_end/inspector.json View 1 chunk +1 line, -0 lines 0 comments Download
D Source/devtools/front_end/sdk/AnimationModel.js View 1 chunk +0 lines, -484 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/module.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sergeyv
5 years, 6 months ago (2015-06-04 14:04:00 UTC) #2
pfeldman
lgtm
5 years, 6 months ago (2015-06-05 14:05:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151263007/1
5 years, 6 months ago (2015-06-05 14:09:39 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 15:07:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196580

Powered by Google App Engine
This is Rietveld 408576698