Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1151263003: Refactoring timing info for ServiceWorker controlled requests [3/3] (Closed)

Created:
5 years, 7 months ago by Kunihiko Sakamoto
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactoring timing info for ServiceWorker controlled requests [3/3] Currently, three timings are collected for ServiceWorker controlled requests: serviceWorkerFetchStart, serviceWorkerFetchReady, and serviceWorkerFetchEnd. However serviceWorkerFetchReady and serviceWorkerFetchEnd are always the same value as sendStart and sendEnd, respectively. This three sided patch removes serviceWorkerFetchReady and serviceWorkerFetchEnd, and renames serviceWorkerFetchStart to workerStart, which is the name used in Navigation Timing and Resource Timing. [1/3] https://codereview.chromium.org/1159663002/ [2/3] https://codereview.chromium.org/1157823003/ [3/3] THIS BUG=465640 TEST=no functional change; all existing tests should pass. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196034

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M Source/platform/exported/WebURLLoadTiming.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
M public/platform/WebURLLoadTiming.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pfeldman
lgtm
5 years, 7 months ago (2015-05-26 05:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151263003/20001
5 years, 7 months ago (2015-05-28 03:05:07 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-28 05:50:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196034

Powered by Google App Engine
This is Rietveld 408576698