VectorICs: Create a StoreICState to more easily create matching code stubs.

VectorICs: Create a StoreICState to more easily create matching code stubs.

This follows the logic of the load ics, in that the base extra ic state is
better encapsulated.

Introduce flag vector_stores to aid development of vector-based store ics.

BUG=
R=jkummerow@chromium.org

Committed: https://crrev.com/3ce81e193d3d8e09aa012737143dadfcb4438b9c
Cr-Commit-Position: refs/heads/master@{#28576}

[mvstanton, 2015-05-22 08:27:11]

Hi Jakob,
Here is some refactoring to aid vector stores, PTAL, thx for it,
--Michael

[Jakob Kummerow, 2015-05-22 08:52:52]

LGTM with a nit.

https://codereview.chromium.org/1151253004/diff/1/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1151253004/diff/1/src/ic/ic.cc#newcode566
src/ic/ic.cc:566: target->extra_ic_state())),
nit: this indentation looks funny. Maybe pull out "Code* code = ...", similar to
StoreIC::Clear() above?

[mvstanton, 2015-05-22 09:12:36]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-05-22 09:12:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1151253004/#ps20001
(title: "Fix nit.")

[commit-bot: I haz the power, 2015-05-22 09:12:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151253004/20001

[mvstanton, 2015-05-22 09:12:56]

Right on, thanks!

https://codereview.chromium.org/1151253004/diff/1/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/1151253004/diff/1/src/ic/ic.cc#newcode566
src/ic/ic.cc:566: target->extra_ic_state())),
On 2015/05/22 08:52:51, Jakob wrote:
> nit: this indentation looks funny. Maybe pull out "Code* code = ...", similar
to
> StoreIC::Clear() above?

Yeah, totally agree, will do.

[commit-bot: I haz the power, 2015-05-22 09:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-22 09:15:52]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/641)

[mvstanton, 2015-05-22 09:19:47]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-05-22 09:19:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1151253004/#ps40001
(title: "Dumb compile error :P.")

[commit-bot: I haz the power, 2015-05-22 09:19:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151253004/40001

[commit-bot: I haz the power, 2015-05-22 09:58:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-22 09:58:21]

Patchset 3 (id:??) landed as
https://crrev.com/3ce81e193d3d8e09aa012737143dadfcb4438b9c
Cr-Commit-Position: refs/heads/master@{#28576}