Chromecast: moves chromecast_switches.* from common/ to base/.

Chromecast: moves chromecast_switches.* from common/ to base/.

It's conceptually inappropriate for the switches to live in common/, as most of them are not content-embedder-specific. (See internal uses).

R=halliwell@chromium.org,alokp@chromium.org

Committed: https://crrev.com/78ceef57fff6570429dc9fe4aa291a512340955d
Cr-Commit-Position: refs/heads/master@{#331127}

[halliwell, 2015-05-22 13:39:08]

On 2015/05/22 07:16:41, gunsch wrote:

lgtm

[alokp, 2015-05-22 16:26:49]

For people not familiar with the purpose of base and common, can you add the
motivation for this change in the patch description?

Are these switches being used processes other than browser and renderer?

[gunsch, 2015-05-22 16:32:39]

On 2015/05/22 16:26:49, Alok Priyadarshi wrote:
> For people not familiar with the purpose of base and common, can you add the
> motivation for this change in the patch description?

Note that as Chromecast changes are within our team, we take a closer approach
to Clank: not everything has to have a public bug, not everything needs a public
motivation. We're still a largely internally-developed project.

That said, I've updated the description to add more details.

> 
> Are these switches being used processes other than browser and renderer?

Not other processes (we don't have other small processes), but other conceptual
parts of the code (see the internal CLs I mailed out) that shouldn't be
depending on "the content folders" (browser, common, renderer). We should
probably be keeping the "content folders" small if possible so that they're not
as monolithic when/if we want to move away from the content-embedder model.

[alokp, 2015-05-22 16:40:50]

lgtm

[gunsch, 2015-05-22 16:45:33]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-05-22 16:45:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1151253003/1

[commit-bot: I haz the power, 2015-05-22 16:50:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-22 16:50:54]

Patchset 1 (id:??) landed as
https://crrev.com/78ceef57fff6570429dc9fe4aa291a512340955d
Cr-Commit-Position: refs/heads/master@{#331127}