Source/core/dom/ProcessingInstruction.idl - Issue 1151203002: Make CharacterData.substringData() and ProcessingInstruction.target not nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ProcessingInstruction.idl

Issue 1151203002: Make CharacterData.substringData() and ProcessingInstruction.target not nullable (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: drop Document changes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ProcessingInstruction.idl

diff --git a/Source/core/dom/ProcessingInstruction.idl b/Source/core/dom/ProcessingInstruction.idl

index 048f210598a45d8f499b1009d4970704e964a178..c645fab30207d6eafa9d0773f1d7e9bd1ec2221a 100644

--- a/Source/core/dom/ProcessingInstruction.idl

+++ b/Source/core/dom/ProcessingInstruction.idl

@@ -21,8 +21,7 @@

// https://dom.spec.whatwg.org/#interface-processinginstruction

interface ProcessingInstruction : CharacterData {

- // FIXME: target should not be nullable.

- readonly attribute DOMString? target;

+ readonly attribute DOMString target;

// FIXME: CharacterData.sheet is not part of any modern spec.

// https://www.w3.org/Bugs/Public/show_bug.cgi?id=28068

« no previous file with comments | « Source/core/dom/CharacterData.idl ('k') | no next file » | no next file with comments »