Issue 1151203002: Make CharacterData.substringData() and ProcessingInstruction.target not nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1151203002: Make CharacterData.substringData() and ProcessingInstruction.target not nullable (Closed)

Created:
5 years, 7 months ago by philipj_slow

Modified:
5 years, 7 months ago

Reviewers:
vivekg, Jens Widell

CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, dglazkov+blink, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Make CharacterData.substringData() and ProcessingInstruction.target not nullable This changes the generated code from v8SetReturnValueStringOrNull(...) to v8SetReturnValueString(...), but none of these can return a null string internally, so the difference should never be observable. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195802

Patch Set 1 #

Patch Set 2 : drop Document changes #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	Source/core/dom/CharacterData.idl	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	Source/core/dom/ProcessingInstruction.idl	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1151203002/20001

5 years, 7 months ago (2015-05-22 15:50:09 UTC) #6

commit-bot: I haz the power

5 years, 7 months ago (2015-05-22 18:35:36 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195802

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages