Use UnlimitedCacheFlushManager for DEFAULT_CACHING_POLICY.

pkg/analyzer/test/src/context/cache_test.dart

Index: pkg/analyzer/test/src/context/cache_test.dart
diff --git a/pkg/analyzer/test/src/context/cache_test.dart b/pkg/analyzer/test/src/context/cache_test.dart
index 4e8909fb33415d15919f137882be5202e7afc196..d40d02d756641eda80f95b78a1bb15b82955950d 100644
--- a/pkg/analyzer/test/src/context/cache_test.dart
+++ b/pkg/analyzer/test/src/context/cache_test.dart
@@ -671,40 +671,40 @@ class CacheFlushManagerTest {
     expect(manager.recentlyUsed, orderedEquals([result1, result3, result2]));
   }
 
-  test_resultAccessed_noSuchResult() {
+  test_resultAccessed_negativeMaxSize() {
+    manager = new CacheFlushManager(new SimpleResultCachingPolicy(-1, -1),
+        (AnalysisTarget target) => false);
     ResultDescriptor descriptor1 = new ResultDescriptor('result1', null);
     ResultDescriptor descriptor2 = new ResultDescriptor('result2', null);
-    ResultDescriptor descriptor3 = new ResultDescriptor('result3', null);
     AnalysisTarget target = new TestSource();
     TargetedResult result1 = new TargetedResult(target, descriptor1);
     TargetedResult result2 = new TargetedResult(target, descriptor2);
-    TargetedResult result3 = new TargetedResult(target, descriptor3);
     manager.resultStored(result1, null);
     manager.resultStored(result2, null);
-    expect(manager.currentSize, 2);
-    expect(manager.recentlyUsed, orderedEquals([result1, result2]));
-    // access result3, no-op
-    manager.resultAccessed(result3);
-    expect(manager.currentSize, 2);
-    expect(manager.recentlyUsed, orderedEquals([result1, result2]));
+    expect(manager.currentSize, 0);
+    expect(manager.recentlyUsed, isEmpty);
+    // access result2
+    manager.resultAccessed(result2);
+    expect(manager.currentSize, 0);
+    expect(manager.recentlyUsed, isEmpty);
   }
 
-  test_resultAccessed_unlimitedCachingPolicy() {
-    manager = new CacheFlushManager(new SimpleResultCachingPolicy(-1, -1),
-        (AnalysisTarget target) => false);
+  test_resultAccessed_noSuchResult() {
     ResultDescriptor descriptor1 = new ResultDescriptor('result1', null);
     ResultDescriptor descriptor2 = new ResultDescriptor('result2', null);
+    ResultDescriptor descriptor3 = new ResultDescriptor('result3', null);
     AnalysisTarget target = new TestSource();
     TargetedResult result1 = new TargetedResult(target, descriptor1);
     TargetedResult result2 = new TargetedResult(target, descriptor2);
+    TargetedResult result3 = new TargetedResult(target, descriptor3);
     manager.resultStored(result1, null);
     manager.resultStored(result2, null);
-    expect(manager.currentSize, 0);
-    expect(manager.recentlyUsed, isEmpty);
-    // access result2
-    manager.resultAccessed(result2);
-    expect(manager.currentSize, 0);
-    expect(manager.recentlyUsed, isEmpty);
+    expect(manager.currentSize, 2);
+    expect(manager.recentlyUsed, orderedEquals([result1, result2]));
+    // access result3, no-op
+    manager.resultAccessed(result3);
+    expect(manager.currentSize, 2);
+    expect(manager.recentlyUsed, orderedEquals([result1, result2]));
   }
 
   test_resultStored() {
@@ -739,7 +739,7 @@ class CacheFlushManagerTest {
     }
   }
 
-  test_resultStored_unlimitedCachingPolicy() {
+  test_resultStored_negativeMaxSize() {
     manager = new CacheFlushManager(new SimpleResultCachingPolicy(-1, -1),
         (AnalysisTarget target) => false);
     ResultDescriptor descriptor1 = new ResultDescriptor('result1', null);