Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: pkg/analysis_server/test/services/correction/fix_test.dart

Issue 1151183003: Issue 23551. Fix for using type parameters of the enclosed classes in 'Create Missing Overrides' Qu… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix_internal.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/fix_test.dart
diff --git a/pkg/analysis_server/test/services/correction/fix_test.dart b/pkg/analysis_server/test/services/correction/fix_test.dart
index d43d0a1d2194ee10e21225ca84521bca98835441..6516f5bd6ef6f8c2496bf6131cedb85c2f3846fa 100644
--- a/pkg/analysis_server/test/services/correction/fix_test.dart
+++ b/pkg/analysis_server/test/services/correction/fix_test.dart
@@ -1545,7 +1545,7 @@ class B extends A {
''');
}
- void test_createMissingOverrides_generics() {
+ void test_createMissingOverrides_generics_typeArguments() {
resolveTestUnit('''
class Iterator<T> {
}
@@ -1573,6 +1573,29 @@ class Test extends IterableMixin<int> {
''');
}
+ void test_createMissingOverrides_generics_typeParameters() {
+ resolveTestUnit('''
+abstract class ItemProvider<T> {
+ List<T> getItems();
+}
+
+class Test<V> extends ItemProvider<V> {
+}
+''');
+ assertHasFix(DartFixKind.CREATE_MISSING_OVERRIDES, '''
+abstract class ItemProvider<T> {
+ List<T> getItems();
+}
+
+class Test<V> extends ItemProvider<V> {
+ @override
+ List<V> getItems() {
+ // TODO: implement getItems
+ }
+}
+''');
+ }
+
void test_createMissingOverrides_getter() {
resolveTestUnit('''
abstract class A {
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix_internal.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698