Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: Source/core/html/canvas/WebGL2RenderingContextBase.h

Issue 1151163002: Oilpan: eagerly finalize WebGLRenderingContext objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add explanatory comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/html/canvas/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "core/html/canvas/WebGLExtension.h" 8 #include "core/html/canvas/WebGLExtension.h"
9 #include "core/html/canvas/WebGLRenderingContextBase.h" 9 #include "core/html/canvas/WebGLRenderingContextBase.h"
10 #include "wtf/PassRefPtr.h" 10 #include "wtf/PassRefPtr.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 GLboolean isVertexArray(WebGLVertexArrayObject*); 159 GLboolean isVertexArray(WebGLVertexArrayObject*);
160 void bindVertexArray(WebGLVertexArrayObject*); 160 void bindVertexArray(WebGLVertexArrayObject*);
161 161
162 /* WebGLRenderingContextBase overrides */ 162 /* WebGLRenderingContextBase overrides */
163 void initializeNewContext() override; 163 void initializeNewContext() override;
164 void bindFramebuffer(GLenum target, WebGLFramebuffer*) override; 164 void bindFramebuffer(GLenum target, WebGLFramebuffer*) override;
165 ScriptValue getParameter(ScriptState*, GLenum pname) override; 165 ScriptValue getParameter(ScriptState*, GLenum pname) override;
166 ScriptValue getTexParameter(ScriptState*, GLenum target, GLenum pname) overr ide; 166 ScriptValue getTexParameter(ScriptState*, GLenum target, GLenum pname) overr ide;
167 ScriptValue getFramebufferAttachmentParameter(ScriptState*, GLenum target, G Lenum attachment, GLenum pname) override; 167 ScriptValue getFramebufferAttachmentParameter(ScriptState*, GLenum target, G Lenum attachment, GLenum pname) override;
168 168
169 EAGERLY_FINALIZE();
169 DECLARE_VIRTUAL_TRACE(); 170 DECLARE_VIRTUAL_TRACE();
170 171
171 protected: 172 protected:
172 WebGL2RenderingContextBase(HTMLCanvasElement*, PassOwnPtr<WebGraphicsContext 3D>, const WebGLContextAttributes& requestedAttributes); 173 WebGL2RenderingContextBase(HTMLCanvasElement*, PassOwnPtr<WebGraphicsContext 3D>, const WebGLContextAttributes& requestedAttributes);
173 174
174 // Helper function to validate target and the attachment combination for get FramebufferAttachmentParameters. 175 // Helper function to validate target and the attachment combination for get FramebufferAttachmentParameters.
175 // Generate GL error and return false if parameters are illegal. 176 // Generate GL error and return false if parameters are illegal.
176 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName, GLenum target, GLenum attachment); 177 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName, GLenum target, GLenum attachment);
177 178
178 bool validateClearBuffer(const char* functionName, GLenum buffer, GLsizei le ngth); 179 bool validateClearBuffer(const char* functionName, GLenum buffer, GLsizei le ngth);
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 RefPtrWillBeMember<WebGLBuffer> m_boundUniformBuffer; 216 RefPtrWillBeMember<WebGLBuffer> m_boundUniformBuffer;
216 }; 217 };
217 218
218 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context, 219 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context,
219 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 220 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
220 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ; 221 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ;
221 222
222 } // namespace blink 223 } // namespace blink
223 224
224 #endif 225 #endif
OLDNEW
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/html/canvas/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698