ash/wm/workspace/workspace_layout_manager.cc - Issue 1151133003: Added an ActivationReason parameter to ActivationChangeObserver::OnWindowActivated(...).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/workspace/workspace_layout_manager.cc

Issue 1151133003: Added an ActivationReason parameter to ActivationChangeObserver::OnWindowActivated(...). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/workspace/workspace_layout_manager.h ('k') | chrome/browser/ui/ash/launcher/app_window_launcher_controller.h » ('j') | ui/wm/core/default_activation_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/workspace/workspace_layout_manager.cc

diff --git a/ash/wm/workspace/workspace_layout_manager.cc b/ash/wm/workspace/workspace_layout_manager.cc

index 63c4aed0e71112d817c63f2d2bd71d113efe85f6..6db10ecb1190edd46b79ae0f1d9471301fdf98cf 100644

--- a/ash/wm/workspace/workspace_layout_manager.cc

+++ b/ash/wm/workspace/workspace_layout_manager.cc

@@ -245,8 +245,10 @@ void WorkspaceLayoutManager::OnWindowBoundsChanged(aura::Window* window,

// WorkspaceLayoutManager,

// aura::client::ActivationChangeObserver implementation:

-void WorkspaceLayoutManager::OnWindowActivated(aura::Window* gained_active,

- aura::Window* lost_active) {

+void WorkspaceLayoutManager::OnWindowActivated(

+ aura::client::ActivationChangeObserver::ActivationReason reason,

+ aura::Window* gained_active,

+ aura::Window* lost_active) {

wm::WindowState* window_state = wm::GetWindowState(gained_active);

if (window_state && window_state->IsMinimized() &&

!gained_active->IsVisible()) {